<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123893/">https://git.reviewboard.kde.org/r/123893/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 24th, 2015, 2:47 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think I understand where you're coming from, but I'm unsure it makes sense.
Won't it be weird if you change your emoticons theme and then it only gets applied for some accounts?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think so.
This way you can use "native" emoticons for every protocol - that is eg. hangouts emoticons for gtalk.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Default settings of course will still be to use emoticon theme set from emoticons kcm.</p></pre>
<br />
<p>- David</p>
<br />
<p>On May 24th, 2015, 11:50 a.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated May 24, 2015, 11:50 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The name of emoticon theme for account is stored in ktelepathyrc and then used by ktp-text-ui.
If there is no specified emoticon theme, the default emoticon theme is used.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This needs UI somewhere in settings to configure the emoticons for each account. I'm not sure where to put it (in kaccounts-kcm?), so suggestions welcome.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works fine</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/emoticon-text-edit-action.h <span style="color: grey">(a5ae531)</span></li>
<li>app/emoticon-text-edit-action.cpp <span style="color: grey">(2ee628e)</span></li>
<li>app/emoticon-text-edit-selector.h <span style="color: grey">(fb1584f)</span></li>
<li>app/emoticon-text-edit-selector.cpp <span style="color: grey">(22742fb)</span></li>
<li>filters/emoticons/CMakeLists.txt <span style="color: grey">(447b223)</span></li>
<li>filters/emoticons/emoticon-filter.h <span style="color: grey">(0f5a1ec)</span></li>
<li>filters/emoticons/emoticon-filter.cpp <span style="color: grey">(565ae84)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(d6af848)</span></li>
<li>lib/emoticons-manager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/emoticons-manager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123893/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>