<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123064/">https://git.reviewboard.kde.org/r/123064/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On März 19th, 2015, 8:40 nachm. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123064/diff/1/?file=355783#file355783line29" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">set</span><span class="p">(</span><span class="s">CMAKE_CXX_FLAGS</span> <span class="s2">"${CMAKE_CXX_FLAGS} ${QTGSTREAMER_FLAGS} ${KDE4_ENABLE_EXCEPTIONS}"</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">kde_enable_exceptions</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do we actually need exceptions?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The GStreamer stuff needs them - without exceptions, it fails to build.</p></pre>
<br />
<p>- Niels Ole</p>
<br />
<p>On März 19th, 2015, 7:12 nachm. UTC, Niels Ole Salscheider wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Niels Ole Salscheider.</div>
<p style="color: grey;"><i>Updated März 19, 2015, 7:12 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-call-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Get rid of KDELibs4Support</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds, starts.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(873dd93eba18e046b20d89a16d4c843f31377a22)</span></li>
<li>libktpcall/CMakeLists.txt <span style="color: grey">(512c9f1476636487bd3165bc599d0ca703c62398)</span></li>
<li>libktpcall/call-channel-handler.cpp <span style="color: grey">(8779b602028b6812892b5c1a8fb01300781eee7a)</span></li>
<li>libktpcall/call-content-handler.cpp <span style="color: grey">(d167835693d6429da11f7f55cd99af92ba7e0d5d)</span></li>
<li>libktpcall/private/device-element-factory.cpp <span style="color: grey">(2d425003a98f87cf45695220bbddf6eb15ffa4c2)</span></li>
<li>libktpcall/private/phonon-integration.cpp <span style="color: grey">(ece6a8b63020ae23cdff202c32942843ed46aa6c)</span></li>
<li>libktpcall/private/sink-controllers.cpp <span style="color: grey">(7ed56139feda9cc73a7366a771ebf63f0aa278bf)</span></li>
<li>libktpcall/private/sink-manager.cpp <span style="color: grey">(1df1c1734d4616bbb15e0cd90a34dad428ef9bde)</span></li>
<li>libktpcall/private/tf-audio-content-handler.cpp <span style="color: grey">(965c19ce2ff057430298d4c4aca5a83d6e7641f3)</span></li>
<li>libktpcall/private/tf-channel-handler.cpp <span style="color: grey">(9d906c571e16323dc8bf8b26b77bad864556ba19)</span></li>
<li>libktpcall/private/tf-content-handler.cpp <span style="color: grey">(a8456e2ccce20ea3076cdd97c21ccf2c5e37c898)</span></li>
<li>libktpcall/private/tf-video-content-handler.cpp <span style="color: grey">(a8a9eca2a8eb88bb3140643f66529d410bc7087c)</span></li>
<li>libktpcall/private/video-sink-bin.cpp <span style="color: grey">(0b95b5c4a4cb30d4aca4ad93cc940f47bb5d9769)</span></li>
<li>libktpcall/tests/CMakeLists.txt <span style="color: grey">(f0377cc5f5873624a62714922284ab1c8375876c)</span></li>
<li>libktpcall/tests/configuration_test.cpp <span style="color: grey">(6b5da6b0e325cda0509a35b862071424807f8cd9)</span></li>
<li>libqtf/CMakeLists.txt <span style="color: grey">(d8841c2590015271489fa7e5c9d5a2e1c3ae69df)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(3cb382648243129a2126cd546059786a4f1fbc77)</span></li>
<li>src/approver.h <span style="color: grey">(442ca3fa426f7d01fa90c7b9174e35c74d490ff7)</span></li>
<li>src/approver.cpp <span style="color: grey">(cab426b7f1241190bb3bfa1b0062aea9e06be8b6)</span></li>
<li>src/call-handler.cpp <span style="color: grey">(75c798491058e0bdd29b0a7618baf86b17048f5c)</span></li>
<li>src/call-manager.cpp <span style="color: grey">(df6e7017f9fb6248c5e5488eb45f7c891d18aa0f)</span></li>
<li>src/call-window.cpp <span style="color: grey">(b4d7e3dfe0b6ded113c9ff7c226f4a3c2cf2d9f4)</span></li>
<li>src/dialout/CMakeLists.txt <span style="color: grey">(242fc2b9691875bf8b285c61849d7c9c7dd6e396)</span></li>
<li>src/dialout/dialout-widget.cpp <span style="color: grey">(2cf5e7f28519f573a3eac1587bc0034a602c46b4)</span></li>
<li>src/dialout/dialout-widget.ui <span style="color: grey">(2ce4793aa5ffe9a1c2dfa1d4363a687f9b873348)</span></li>
<li>src/dtmf-qml.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml-interface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/status-area.h <span style="color: grey">(bf7bdf5572857f438597914a0bc35c3124ee4637)</span></li>
<li>src/status-area.cpp <span style="color: grey">(b8a36d3855ee9ab67a8e3ad6107e9e3615a41148)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123064/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>