<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122391/">https://git.reviewboard.kde.org/r/122391/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note that actions on subcontacts in contact list are broken, it has to do with requiring PersonData for the actions now because for a subcontact, PersonData should return its own Person, ie the parent contact (that was the original design), that's something that should be looked into</p></pre>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On February 2nd, 2015, 7:26 p.m. CET, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDEPIM and Telepathy.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2015, 7:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkpeople
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Moves the QActions facilities to KPeopleWidgets, this way KPeople organization makes more sense, as we already had a KPeopleWidgets anyway.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems to work, requires trivial patches to ktp-common-internals and ktp-contact-list.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(fb8db35)</span></li>
<li>src/backends/abstractpersonaction.h <span style="color: grey">(396190d)</span></li>
<li>src/declarative/CMakeLists.txt <span style="color: grey">(8fd4bf4)</span></li>
<li>src/declarative/personactionsmodel.cpp <span style="color: grey">(8120605)</span></li>
<li>src/global.h <span style="color: grey">(52ff586)</span></li>
<li>src/global.cpp <span style="color: grey">(b5335b2)</span></li>
<li>src/persondata.h <span style="color: grey">(450f4d3)</span></li>
<li>src/personpluginmanager.cpp <span style="color: grey">(6469138)</span></li>
<li>src/widgets/CMakeLists.txt <span style="color: grey">(bceca8c)</span></li>
<li>src/widgets/actions.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/widgets/actions.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122391/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>