<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122188/">https://git.reviewboard.kde.org/r/122188/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniel Vrátil.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2015, 7:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[TelpathyLoggerQt] Port to ECM</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
telepathy-logger-qt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port TelepathyLoggerQt to ECM. It makes the buildsystem much simpler and actually maintainable.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built TpLoggerQt with this patch, built k-c-i against it, tried accessing logs from ktp-log-viewer...and it worked!</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/Qt5Macros.cmake <span style="color: grey">(e7eb0cb)</span></li>
<li>cmake/modules/QtMacros.cmake <span style="color: grey">(9f8f998)</span></li>
<li>cmake/modules/TelepathyDefaults.cmake <span style="color: grey">(b926246)</span></li>
<li>cmake/modules/TelepathyDist.cmake <span style="color: grey">(8d6fadd)</span></li>
<li>TelepathyLoggerQt/pending-entities.h <span style="color: grey">(325c9fb)</span></li>
<li>TelepathyLoggerQt/pending-entities.cpp <span style="color: grey">(7b3f0a8)</span></li>
<li>TelepathyLoggerQt/pending-events.h <span style="color: grey">(a87c884)</span></li>
<li>TelepathyLoggerQt/pending-events.cpp <span style="color: grey">(143f609)</span></li>
<li>TelepathyLoggerQt/pending-log-walker-operation.h <span style="color: grey">(531a37d)</span></li>
<li>TelepathyLoggerQt/pending-log-walker-operation.cpp <span style="color: grey">(46f82e4)</span></li>
<li>TelepathyLoggerQt/pending-operation.h <span style="color: grey">(d48d941)</span></li>
<li>TelepathyLoggerQt/pending-operation.cpp <span style="color: grey">(da302f3)</span></li>
<li>TelepathyLoggerQt/pending-search.h <span style="color: grey">(ab4b246)</span></li>
<li>TelepathyLoggerQt/pending-search.cpp <span style="color: grey">(db3076e)</span></li>
<li>TelepathyLoggerQt/search-hit.h <span style="color: grey">(f12d694)</span></li>
<li>TelepathyLoggerQt/search-hit.cpp <span style="color: grey">(50ab25f)</span></li>
<li>TelepathyLoggerQt/text-event.h <span style="color: grey">(0a9d410)</span></li>
<li>TelepathyLoggerQt/text-event.cpp <span style="color: grey">(ea5be41)</span></li>
<li>TelepathyLoggerQt/types.h <span style="color: grey">(3670075)</span></li>
<li>TelepathyLoggerQt/utils.h <span style="color: grey">(378fb23)</span></li>
<li>TelepathyLoggerQt/utils.cpp <span style="color: grey">(e39b494)</span></li>
<li>cmake/modules/BasicFindPackageVersion.cmake.in <span style="color: grey">(2be6d9e)</span></li>
<li>cmake/modules/InstallSettings.cmake <span style="color: grey">(b8a79bb)</span></li>
<li>cmake/modules/MacroWriteBasicCMakeVersionFile.cmake <span style="color: grey">(d23d857)</span></li>
<li>TelepathyLoggerQt/call-event.cpp <span style="color: grey">(fd3a3ec)</span></li>
<li>TelepathyLoggerQt/entity.h <span style="color: grey">(2a2520a)</span></li>
<li>TelepathyLoggerQt/entity.cpp <span style="color: grey">(8c37893)</span></li>
<li>TelepathyLoggerQt/event.h <span style="color: grey">(96c275a)</span></li>
<li>TelepathyLoggerQt/event.cpp <span style="color: grey">(15c1ae1)</span></li>
<li>TelepathyLoggerQt/global.h <span style="color: grey">(491861f)</span></li>
<li>TelepathyLoggerQt/init.h <span style="color: grey">(6848539)</span></li>
<li>TelepathyLoggerQt/init.cpp <span style="color: grey">(7e925b3)</span></li>
<li>TelepathyLoggerQt/log-manager.h <span style="color: grey">(3679660)</span></li>
<li>TelepathyLoggerQt/log-manager.cpp <span style="color: grey">(b113d4d)</span></li>
<li>TelepathyLoggerQt/log-walker.h <span style="color: grey">(a2ef313)</span></li>
<li>TelepathyLoggerQt/log-walker.cpp <span style="color: grey">(7add228)</span></li>
<li>TelepathyLoggerQt/object.h <span style="color: grey">(4f140b1)</span></li>
<li>TelepathyLoggerQt/pending-clear.h <span style="color: grey">(75c88bd)</span></li>
<li>TelepathyLoggerQt/pending-clear.cpp <span style="color: grey">(e26c719)</span></li>
<li>TelepathyLoggerQt/pending-dates.h <span style="color: grey">(ba2772b)</span></li>
<li>TelepathyLoggerQt/pending-dates.cpp <span style="color: grey">(d690c3c)</span></li>
<li>CMakeLists.txt <span style="color: grey">(eeab518)</span></li>
<li>TelepathyLoggerQt/CMakeLists.txt <span style="color: grey">(8c84f29)</span></li>
<li>TelepathyLoggerQt/CallEvent <span style="color: grey">(ddac7fb)</span></li>
<li>TelepathyLoggerQt/Entity <span style="color: grey">(4f1f0b7)</span></li>
<li>TelepathyLoggerQt/Event <span style="color: grey">(2a0e8ed)</span></li>
<li>TelepathyLoggerQt/Global <span style="color: grey">(ecf1d7d)</span></li>
<li>TelepathyLoggerQt/Init <span style="color: grey">(f8a2430)</span></li>
<li>TelepathyLoggerQt/LogManager <span style="color: grey">(580cf87)</span></li>
<li>TelepathyLoggerQt/LogWalker <span style="color: grey">(bd2a0fe)</span></li>
<li>TelepathyLoggerQt/Object <span style="color: grey">(3dd41b2)</span></li>
<li>TelepathyLoggerQt/PendingDates <span style="color: grey">(46ffe6e)</span></li>
<li>TelepathyLoggerQt/PendingEntities <span style="color: grey">(7007da7)</span></li>
<li>TelepathyLoggerQt/PendingEvents <span style="color: grey">(df4c775)</span></li>
<li>TelepathyLoggerQt/PendingOperation <span style="color: grey">(5521ac5)</span></li>
<li>TelepathyLoggerQt/PendingSearch <span style="color: grey">(7b38788)</span></li>
<li>TelepathyLoggerQt/SearchHit <span style="color: grey">(f05782e)</span></li>
<li>TelepathyLoggerQt/TelepathyLoggerQtConfig.cmake.in <span style="color: grey">(ca7f0cc)</span></li>
<li>TelepathyLoggerQt/TextEvent <span style="color: grey">(98072c1)</span></li>
<li>TelepathyLoggerQt/Types <span style="color: grey">(471c141)</span></li>
<li>TelepathyLoggerQt/call-event.h <span style="color: grey">(e820a2e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122188/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>