<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121639/">https://git.reviewboard.kde.org/r/121639/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 29th, 2014, 2:26 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121639/diff/1/?file=335573#file335573line57" style="color: black; font-weight: bold; text-decoration: underline;">autotests/fakecontactsource.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">57</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">QStringList</span><span class="p">(</span><span class="n">m_properties</span><span class="p">[</span><span class="n">key</span><span class="p">.</span><span class="n">mid</span><span class="p">(</span><span class="mi">4</span><span class="p">)].</span><span class="n">toString</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">currently this is unused, which means we can't be testing where we have multiple properties </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">also I don't really understand what this line would be doing, turning a variant into a string and then into a stringlist and then into a variant?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I guess I'll have to document this better.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The idea is that if you request "all-something" you are requesting all the alternatives of "something" and requesting "something" returns just the preferred value by any metric.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I guess this might not be a very intuitive API, maybe we'd prefer to have an extra argument in customProperty specifying the cardinality? something like enum Amount { Preferred, All } and then we know that All is a list of the type in Preferred.</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 29th, 2014, 2:26 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121639/diff/1/?file=335589#file335589line38" style="color: black; font-weight: bold; text-decoration: underline;">src/defaultcontactmonitor.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">DefaultContactMonitor</span><span class="o">::</span><span class="n">onContactAdded</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span><span class="o">&</span> <span class="n">id</span><span class="p">,</span> <span class="k">const</span> <span class="n"><span class="hl">K</span>Contact<span class="hl">s</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">Addressee</span></span><span class="o">&</span> <span class="n">contact</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">37</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">DefaultContactMonitor</span><span class="o">::</span><span class="n">onContactAdded</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span><span class="o">&</span> <span class="n">id</span><span class="p">,</span> <span class="k">const</span> <span class="n"><span class="hl">Abstract</span>Contact</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">Ptr</span></span><span class="o">&</span> <span class="n">contact</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">given we now control AbstractContact we can put the ID in that. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Will simplify a few APIs</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So you propose it should be a property? or?</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 29th, 2014, 2:26 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121639/diff/1/?file=335596#file335596line52" style="color: black; font-weight: bold; text-decoration: underline;">src/metacontact.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">51</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QVariant</span> <span class="n">val</span> <span class="o">=</span> <span class="n">contact</span><span class="o">-></span><span class="n">customProperty</span><span class="p">(</span><span class="n">prop</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">merging behaviour isn't this simple.
It change on the property, especially for cardinality.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if I request a name I don't want to get a list, and it's especially important as we can use the redesign to not bother querying for data we're not going to show.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It also makes the usage more complex where clients now have to start handling lists, and grouping all emails (now a list of lists) together.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See the first comment in here, note the "all-" part of the if().</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 29th, 2014, 2:26 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121639/diff/1/?file=335596#file335596line68" style="color: black; font-weight: bold; text-decoration: underline;">src/metacontact.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">AbstractContact</span><span class="o">::</span><span class="n">List</span> <span class="n">m_contacts</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">deliberately public?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Eh well... it's the private implementation. they are usually public, no?</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 29th, 2014, 2:26 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121639/diff/1/?file=335599#file335599line156" style="color: black; font-weight: bold; text-decoration: underline;">src/persondata.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">149</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">customProperty</span><span class="p">(</span><span class="n">AbstractContact</span><span class="o">::</span><span class="n">NameProperty</span><span class="p">).</span><span class="n">toString</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We're converting a list of variants to a string?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not entirely sure what the behaviour will be, but I doubt it's what we want.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why do you say it's a list?</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On December 24th, 2014, 1:07 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDEPIM, Telepathy, Christian Mollekopf, David Edmundson, and Martin Klapetek.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Dec. 24, 2014, 1:07 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkpeople
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Last week we had a couple of discussions regarding KPeople relationship with KDE PIM and KContacts and we agreed that we want to keep KContacts as a framework that is good at dealing with vCards, which leaves KPeople without a good way to send around its data.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch proposes an internal AbstractContact class that the backends will have to re-implement. At the moment it only requires a "customProperty" that lets us fetch whatever is needed.
Furthermore, it also includes a set of convenience methods in PersonData to have a type-safe API.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds, the test passes. ktp tests work, somewhat.
Also there's few tests altogether.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3df5f0b)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(676f170)</span></li>
<li>autotests/fakecontactsource.h <span style="color: grey">(981fe03)</span></li>
<li>autotests/fakecontactsource.cpp <span style="color: grey">(269f94f)</span></li>
<li>autotests/persondatatests.cpp <span style="color: grey">(47a6213)</span></li>
<li>examples/CMakeLists.txt <span style="color: grey">(74bd188)</span></li>
<li>examples/duplicates.cpp <span style="color: grey">(72ff53b)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(534066b)</span></li>
<li>src/backends/abstractcontact.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/abstractcontact.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/abstractpersonaction.h <span style="color: grey">(703063e)</span></li>
<li>src/backends/abstractpersonaction.cpp <span style="color: grey">(be93d90)</span></li>
<li>src/backends/allcontactsmonitor.h <span style="color: grey">(47e5dfd)</span></li>
<li>src/backends/allcontactsmonitor.cpp <span style="color: grey">(e517f17)</span></li>
<li>src/backends/basepersonsdatasource.h <span style="color: grey">(3c25e28)</span></li>
<li>src/backends/basepersonsdatasource.cpp <span style="color: grey">(b794917)</span></li>
<li>src/backends/contactmonitor.h <span style="color: grey">(cf25953)</span></li>
<li>src/backends/contactmonitor.cpp <span style="color: grey">(ceb5d74)</span></li>
<li>src/declarative/personactionsmodel.cpp <span style="color: grey">(4b34e15)</span></li>
<li>src/defaultcontactmonitor.cpp <span style="color: grey">(36c31a7)</span></li>
<li>src/defaultcontactmonitor_p.h <span style="color: grey">(8fc2812)</span></li>
<li>src/duplicatesfinder.cpp <span style="color: grey">(c6a1014)</span></li>
<li>src/global.h <span style="color: grey">(9540623)</span></li>
<li>src/global.cpp <span style="color: grey">(3ef834b)</span></li>
<li>src/match.cpp <span style="color: grey">(3a93aba)</span></li>
<li>src/match_p.h <span style="color: grey">(5727270)</span></li>
<li>src/metacontact.cpp <span style="color: grey">(bba6b65)</span></li>
<li>src/metacontact_p.h <span style="color: grey">(0d738cc)</span></li>
<li>src/persondata.h <span style="color: grey">(66b19a3)</span></li>
<li>src/persondata.cpp <span style="color: grey">(dab9f61)</span></li>
<li>src/personpluginmanager.cpp <span style="color: grey">(f249b5f)</span></li>
<li>src/personsmodel.h <span style="color: grey">(db907d4)</span></li>
<li>src/personsmodel.cpp <span style="color: grey">(ca6e972)</span></li>
<li>src/plugins/akonadi/akonadidatasource.cpp <span style="color: grey">(ae4ace1)</span></li>
<li>src/widgets/abstractfieldwidgetfactory.h <span style="color: grey">(1d2d8aa)</span></li>
<li>src/widgets/persondetailsdialog.cpp <span style="color: grey">(8ca0a99)</span></li>
<li>src/widgets/persondetailsview.cpp <span style="color: grey">(b7535bd)</span></li>
<li>src/widgets/plugins/emaildetailswidget.h <span style="color: grey">(72a96ee)</span></li>
<li>src/widgets/plugins/emaildetailswidget.cpp <span style="color: grey">(839c5f6)</span></li>
<li>src/widgets/plugins/emails.h <span style="color: grey">(ede1686)</span></li>
<li>src/widgets/plugins/emails.cpp <span style="color: grey">(d69101b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121639/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>