<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121639/">https://git.reviewboard.kde.org/r/121639/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ping?</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On December 24th, 2014, 1:07 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDEPIM, Telepathy, Christian Mollekopf, David Edmundson, and Martin Klapetek.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Dec. 24, 2014, 1:07 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkpeople
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Last week we had a couple of discussions regarding KPeople relationship with KDE PIM and KContacts and we agreed that we want to keep KContacts as a framework that is good at dealing with vCards, which leaves KPeople without a good way to send around its data.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch proposes an internal AbstractContact class that the backends will have to re-implement. At the moment it only requires a "customProperty" that lets us fetch whatever is needed.
Furthermore, it also includes a set of convenience methods in PersonData to have a type-safe API.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds, the test passes. ktp tests work, somewhat.
Also there's few tests altogether.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3df5f0b)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(676f170)</span></li>
<li>autotests/fakecontactsource.h <span style="color: grey">(981fe03)</span></li>
<li>autotests/fakecontactsource.cpp <span style="color: grey">(269f94f)</span></li>
<li>autotests/persondatatests.cpp <span style="color: grey">(47a6213)</span></li>
<li>examples/CMakeLists.txt <span style="color: grey">(74bd188)</span></li>
<li>examples/duplicates.cpp <span style="color: grey">(72ff53b)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(534066b)</span></li>
<li>src/backends/abstractcontact.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/abstractcontact.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/abstractpersonaction.h <span style="color: grey">(703063e)</span></li>
<li>src/backends/abstractpersonaction.cpp <span style="color: grey">(be93d90)</span></li>
<li>src/backends/allcontactsmonitor.h <span style="color: grey">(47e5dfd)</span></li>
<li>src/backends/allcontactsmonitor.cpp <span style="color: grey">(e517f17)</span></li>
<li>src/backends/basepersonsdatasource.h <span style="color: grey">(3c25e28)</span></li>
<li>src/backends/basepersonsdatasource.cpp <span style="color: grey">(b794917)</span></li>
<li>src/backends/contactmonitor.h <span style="color: grey">(cf25953)</span></li>
<li>src/backends/contactmonitor.cpp <span style="color: grey">(ceb5d74)</span></li>
<li>src/declarative/personactionsmodel.cpp <span style="color: grey">(4b34e15)</span></li>
<li>src/defaultcontactmonitor.cpp <span style="color: grey">(36c31a7)</span></li>
<li>src/defaultcontactmonitor_p.h <span style="color: grey">(8fc2812)</span></li>
<li>src/duplicatesfinder.cpp <span style="color: grey">(c6a1014)</span></li>
<li>src/global.h <span style="color: grey">(9540623)</span></li>
<li>src/global.cpp <span style="color: grey">(3ef834b)</span></li>
<li>src/match.cpp <span style="color: grey">(3a93aba)</span></li>
<li>src/match_p.h <span style="color: grey">(5727270)</span></li>
<li>src/metacontact.cpp <span style="color: grey">(bba6b65)</span></li>
<li>src/metacontact_p.h <span style="color: grey">(0d738cc)</span></li>
<li>src/persondata.h <span style="color: grey">(66b19a3)</span></li>
<li>src/persondata.cpp <span style="color: grey">(dab9f61)</span></li>
<li>src/personpluginmanager.cpp <span style="color: grey">(f249b5f)</span></li>
<li>src/personsmodel.h <span style="color: grey">(db907d4)</span></li>
<li>src/personsmodel.cpp <span style="color: grey">(ca6e972)</span></li>
<li>src/plugins/akonadi/akonadidatasource.cpp <span style="color: grey">(ae4ace1)</span></li>
<li>src/widgets/abstractfieldwidgetfactory.h <span style="color: grey">(1d2d8aa)</span></li>
<li>src/widgets/persondetailsdialog.cpp <span style="color: grey">(8ca0a99)</span></li>
<li>src/widgets/persondetailsview.cpp <span style="color: grey">(b7535bd)</span></li>
<li>src/widgets/plugins/emaildetailswidget.h <span style="color: grey">(72a96ee)</span></li>
<li>src/widgets/plugins/emaildetailswidget.cpp <span style="color: grey">(839c5f6)</span></li>
<li>src/widgets/plugins/emails.h <span style="color: grey">(ede1686)</span></li>
<li>src/widgets/plugins/emails.cpp <span style="color: grey">(d69101b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121639/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>