<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121544/">https://git.reviewboard.kde.org/r/121544/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121544/diff/1/?file=333443#file333443line156" style="color: black; font-weight: bold; text-decoration: underline;">cmake/modules/TelepathyDefaults.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">156</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">set</span><span class="p">(</span><span class="s"><span class="hl">LIB</span>_INSTALL_DIR</span><span class="hl"> </span><span class="s2"><span class="hl">"lib${LIB_SUFFIX}"</span></span><span class="hl"> </span> <span class="s">CACHE</span> <span class="s">PATH</span> <span class="s2">"The subdirectory where <span class="hl">librari</span>es will be installed (default is ${CMAKE_INSTALL_PREFIX}/<span class="hl">lib${LIB_SUFFIX}</span>)"</span> <span class="s">FORCE</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">156</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">set</span><span class="p">(</span><span class="s"><span class="hl">INCLUDE_DESTINATION</span></span><span class="hl"> </span><span class="s2"><span class="hl">"${CMAKE</span>_INSTALL_<span class="hl">FULL_INCLUDE</span>DIR<span class="hl">}"</span></span> <span class="s">CACHE</span> <span class="s">PATH</span> <span class="s2">"The subdirectory where <span class="hl">header fil</span>es will be installed (default is ${CMAKE_INSTALL_PREFIX}/<span class="hl">include</span>)"</span> <span class="s">FORCE</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">FORCE shouldn't be needed.</p></pre>
</div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good to me.</p></pre>
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On December 15th, 2014, 11:30 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy and Aleix Pol Gonzalez.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Dec. 15, 2014, 11:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
telepathy-logger-qt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this is less fragile in abs. vs. relative paths, etc..</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">so far tried only cmake sets correct vars...</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(0022600)</span></li>
<li>TelepathyLoggerQt/CMakeLists.txt <span style="color: grey">(125b56b)</span></li>
<li>TelepathyLoggerQt/TelepathyLoggerQt.pc.in <span style="color: grey">(508fe25)</span></li>
<li>TelepathyLoggerQt/TelepathyLoggerQtConfig.cmake.in <span style="color: grey">(0a4eef9)</span></li>
<li>cmake/modules/TelepathyDefaults.cmake <span style="color: grey">(ec091e2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121544/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>