<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121412/">https://git.reviewboard.kde.org/r/121412/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>









<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/121412/diff/1/?file=332388#file332388line129" style="color: black; font-weight: bold; text-decoration: underline;">tooltips/persontooltip.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString PersonToolTip::getTextWithHyperlinks(QString text)</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="n">result</span> <span class="o">+=</span> <span class="n">QString</span><span class="p">(</span><span class="s">"<a href=</span><span class="se">\"</span><span class="s">%1</span><span class="se">\"</span><span class="s">>%2</a>"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">Q<span class="hl">t</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">escape</span></span><span class="p">(</span><span class="n">fixedLink</span><span class="p">)).</span><span class="n">arg</span><span class="p">(</span><span class="n">Q<span class="hl">t</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">escape</span></span><span class="p">(</span><span class="n">displayLink</span><span class="p">));</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="n">result</span> <span class="o">+=</span> <span class="n">QString</span><span class="p">(</span><span class="s">"<a href=</span><span class="se">\"</span><span class="s">%1</span><span class="se">\"</span><span class="s">>%2</a>"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">Q<span class="hl">String</span></span><span class="p">(</span><span class="n">fixedLink</span><span class="p">)<span class="hl">.</span></span><span class="n"><span class="hl">toHtmlEscaped</span></span><span class="p"><span class="hl">()</span>).</span><span class="n">arg</span><span class="p">(</span><span class="n">Q<span class="hl">String</span></span><span class="p">(</span><span class="n">displayLink</span><span class="p">)<span class="hl">.</span></span><span class="n"><span class="hl">toHtmlEscaped</span></span><span class="p"><span class="hl">()</span>);</span></pre></td>
  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QString("...") -> QStringLiteral("...")</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why do we need to construct a new QString to call toHtmlEscaped? It's const.</p></pre>
 </div>
</div>
<br />



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Small nitpick, looks good otherwise.</p></pre>

<p>- Aleix Pol Gonzalez</p>


<br />
<p>On December 9th, 2014, 4:59 p.m. UTC, Martin Klapetek wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Martin Klapetek.</div>


<p style="color: grey;"><i>Updated Dec. 9, 2014, 4:59 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-contact-list
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kdelibs4support free</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds, it runs, things seem to work fine</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>empty-row-filter.cpp <span style="color: grey">(01b2b48)</span></li>

 <li>filter-bar.cpp <span style="color: grey">(e912bbf)</span></li>

 <li>global-presence-chooser.h <span style="color: grey">(e41ae07)</span></li>

 <li>global-presence-chooser.cpp <span style="color: grey">(ce0c460)</span></li>

 <li>ktp-contactlist-debug.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>ktp-contactlist-debug.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>main-widget.h <span style="color: grey">(3ece8a3)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(3d25114)</span></li>

 <li>account-button.h <span style="color: grey">(19eefb2)</span></li>

 <li>account-button.cpp <span style="color: grey">(574b72a)</span></li>

 <li>account-buttons-panel.h <span style="color: grey">(3e7f9b6)</span></li>

 <li>account-buttons-panel.cpp <span style="color: grey">(7c6712e)</span></li>

 <li>contact-delegate-compact.cpp <span style="color: grey">(58196f5)</span></li>

 <li>contact-delegate-overlay.h <span style="color: grey">(0357c5d)</span></li>

 <li>contact-delegate-overlay.cpp <span style="color: grey">(4b14c5f)</span></li>

 <li>contact-delegate.cpp <span style="color: grey">(3c1488d)</span></li>

 <li>contact-list-widget.cpp <span style="color: grey">(a0fa922)</span></li>

 <li>contact-overlays.cpp <span style="color: grey">(62f9bda)</span></li>

 <li>contact-view-hover-button.cpp <span style="color: grey">(166d392)</span></li>

 <li>context-menu.h <span style="color: grey">(bec4e55)</span></li>

 <li>context-menu.cpp <span style="color: grey">(2dffd02)</span></li>

 <li>dialogs/custom-presence-dialog.h <span style="color: grey">(5b785b0)</span></li>

 <li>dialogs/custom-presence-dialog.cpp <span style="color: grey">(67e812d)</span></li>

 <li>dialogs/remove-contact-dialog.h <span style="color: grey">(362f069)</span></li>

 <li>dialogs/remove-contact-dialog.cpp <span style="color: grey">(2c88887)</span></li>

 <li>main-widget.cpp <span style="color: grey">(cecfdb0)</span></li>

 <li>main-widget.ui <span style="color: grey">(88bac7b)</span></li>

 <li>main.cpp <span style="color: grey">(5424ca6)</span></li>

 <li>tooltips/contacttooltip.cpp <span style="color: grey">(557a4aa)</span></li>

 <li>tooltips/ktooltip.cpp <span style="color: grey">(6e82718)</span></li>

 <li>tooltips/ktooltipwindow.cpp <span style="color: grey">(f321c24)</span></li>

 <li>tooltips/persontooltip.cpp <span style="color: grey">(6b3bb2b)</span></li>

 <li>tooltips/tooltipmanager.cpp <span style="color: grey">(2315d35)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121412/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>