<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119941/">https://git.reviewboard.kde.org/r/119941/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Kudos on keeping the "strange" name tradition...</p></pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/119941/file/1523/" style="color: black; font-weight: bold; font-size: 9pt;">breeze1.jpg</a>
<p>breeze1.jpg</p>
<div><img class="modified-image" src="" width="37" height="41" alt="Is there not a telegram icon we could use?" /></div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is there not a telegram icon we could use?</p></pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119941/diff/1/?file=307671#file307671line44" style="color: black; font-weight: bold; text-decoration: underline;">plugins/morse/morse-account-ui-plugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// We only support <span class="hl">butterfly</span>/xmpp combination.</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// We only support <span class="hl">morse</span>/xmpp combination.</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"morse/telegram"? Or remove completely?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119941/diff/1/?file=307672#file307672line4" style="color: black; font-weight: bold; text-decoration: underline;">plugins/morse/telegram-account-ui.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Copyright (C) 2009 Collabora Ltd. <info@collabora.com></span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Copyright (C) 2009 Collabora Ltd. <info@collabora.com></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe you want to change the copyright?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119941/diff/1/?file=307672#file307672line21" style="color: black; font-weight: bold; text-decoration: underline;">plugins/morse/telegram-account-ui.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#ifndef KCMTELEPATHYACCOUNTS_PLUGIN_BUTTERFLY_ACCOUNT_UI_H</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#ifndef KCMTELEPATHYACCOUNTS_PLUGIN_BUTTERFLY_ACCOUNT_UI_H</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#define KCMTELEPATHYACCOUNTS_PLUGIN_BUTTERFLY_ACCOUNT_UI_H</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#define KCMTELEPATHYACCOUNTS_PLUGIN_BUTTERFLY_ACCOUNT_UI_H</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Needs changing too</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119941/diff/1/?file=307672#file307672line26" style="color: black; font-weight: bold; text-decoration: underline;">plugins/morse/telegram-account-ui.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n"><span class="hl">Butterfly</span>AccountUi</span> <span class="o">:</span> <span class="n">public</span> <span class="n">AbstractAccountUi</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n"><span class="hl">Telegram</span>AccountUi</span> <span class="o">:</span> <span class="n">public</span> <span class="n">AbstractAccountUi</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why is it called "Morse" and then in the code "Telegram"? That should be consistent</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119941/diff/1/?file=307674#file307674line4" style="color: black; font-weight: bold; text-decoration: underline;">plugins/morse/ktpaccountskcm_plugin_morse.desktop.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">Comment[bs]=Prilagođena</span> <span class="err">konfiguracija</span> <span class="err">korisničkog</span> <span class="err">naloga</span> <span class="err">pomoću</span> <span class="err">upravitelja</span> <span class="err">Butterfly</span> <span class="err">veze.</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">Comment[bs]=Prilagođena</span> <span class="err">konfiguracija</span> <span class="err">korisničkog</span> <span class="err">naloga</span> <span class="err">pomoću</span> <span class="err">upravitelja</span> <span class="err">Butterfly</span> <span class="err">veze.</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">5</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">Comment[ca]=Interfície</span> <span class="err">d'usuari</span> <span class="err">de</span> <span class="err">configuració</span> <span class="err">de</span> <span class="err">compte</span> <span class="err">personalitzat</span> <span class="err">per</span> <span class="err">comptes</span> <span class="err">que</span> <span class="err">utilitzen</span> <span class="err">el</span> <span class="err">gestor</span> <span class="err">de</span> <span class="err">connexions</span> <span class="err">Butterfly.</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">5</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">Comment[ca]=Interfície</span> <span class="err">d'usuari</span> <span class="err">de</span> <span class="err">configuració</span> <span class="err">de</span> <span class="err">compte</span> <span class="err">personalitzat</span> <span class="err">per</span> <span class="err">comptes</span> <span class="err">que</span> <span class="err">utilitzen</span> <span class="err">el</span> <span class="err">gestor</span> <span class="err">de</span> <span class="err">connexions</span> <span class="err">Butterfly.</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">Comment[ca@valencia]=Interfície</span> <span class="err">d'usuari</span> <span class="err">de</span> <span class="err">configuració</span> <span class="err">de</span> <span class="err">compte</span> <span class="err">personalitzat</span> <span class="err">per</span> <span class="err">comptes</span> <span class="err">que</span> <span class="err">utilitzen</span> <span class="err">el</span> <span class="err">gestor</span> <span class="err">de</span> <span class="err">connexions</span> <span class="err">Butterfly.</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">Comment[ca@valencia]=Interfície</span> <span class="err">d'usuari</span> <span class="err">de</span> <span class="err">configuració</span> <span class="err">de</span> <span class="err">compte</span> <span class="err">personalitzat</span> <span class="err">per</span> <span class="err">comptes</span> <span class="err">que</span> <span class="err">utilitzen</span> <span class="err">el</span> <span class="err">gestor</span> <span class="err">de</span> <span class="err">connexions</span> <span class="err">Butterfly.</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">7</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">Comment[cs]=Vlastní</span> <span class="err">uživatelské</span> <span class="err">rozhraní</span> <span class="err">nastavení</span> <span class="err">účtů</span> <span class="err">pro</span> <span class="err">účty</span> <span class="err">používající</span> <span class="err">správce</span> <span class="err">spojení</span> <span class="err">Butterfly.</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">7</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">Comment[cs]=Vlastní</span> <span class="err">uživatelské</span> <span class="err">rozhraní</span> <span class="err">nastavení</span> <span class="err">účtů</span> <span class="err">pro</span> <span class="err">účty</span> <span class="err">používající</span> <span class="err">správce</span> <span class="err">spojení</span> <span class="err">Butterfly.</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">8</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">Comment[da]=Brugerflade</span> <span class="err">til</span> <span class="err">brugertilpasset</span> <span class="err">kontokonfiguration</span> <span class="err">til</span> <span class="err">konti</span> <span class="err">der</span> <span class="err">bruger</span> <span class="err">forbindelseshåndteringen</span> <span class="err">Butterfly.</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">8</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">Comment[da]=Brugerflade</span> <span class="err">til</span> <span class="err">brugertilpasset</span> <span class="err">kontokonfiguration</span> <span class="err">til</span> <span class="err">konti</span> <span class="err">der</span> <span class="err">bruger</span> <span class="err">forbindelseshåndteringen</span> <span class="err">Butterfly.</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Either remove all the other languages or replace Butterfly with Morse too in there</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119941/diff/1/?file=307674#file307674line54" style="color: black; font-weight: bold; text-decoration: underline;">plugins/morse/ktpaccountskcm_plugin_morse.desktop.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">X-KDE-PluginInfo-License=GPL</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">X-KDE-PluginInfo-License=GPL</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The plugin is actually LGPL</p></pre>
</div>
</div>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On August 26th, 2014, 7:02 p.m. CEST, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2014, 7:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-accounts-kcm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add Accounts KCM Plugin for Telegram</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Mostly boiler plate, nothing exciting.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/butterfly/butterfly-account-ui.cpp <span style="color: grey">(bacc148)</span></li>
<li>plugins/butterfly/ktpaccountskcm_plugin_butterfly.desktop.cmake <span style="color: grey">(0be40a3)</span></li>
<li>plugins/butterfly/main-options-widget.h <span style="color: grey">()</span></li>
<li>plugins/butterfly/main-options-widget.cpp <span style="color: grey">(d787b07)</span></li>
<li>plugins/butterfly/main-options-widget.ui <span style="color: grey">(e3df55b)</span></li>
<li>plugins/gabble/gabble-account-ui-plugin.h <span style="color: grey">(954a9ed)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(994fab4)</span></li>
<li>plugins/butterfly/CMakeLists.txt <span style="color: grey">(1d5d289)</span></li>
<li>plugins/butterfly/Messages.sh <span style="color: grey">()</span></li>
<li>plugins/butterfly/butterfly-account-ui-plugin.cpp <span style="color: grey">(25333e4)</span></li>
<li>plugins/butterfly/butterfly-account-ui.h <span style="color: grey">(1845570)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119941/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/26/7ae0a7fe-284e-4003-b5b0-e687629ac266__breeze1.jpg">breeze1.jpg</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>