<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118237/">https://git.reviewboard.kde.org/r/118237/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2014, 2:11 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bugs: <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- toggling group mode means we lose showing which rooms we're in<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- crash (D_ed can work round in KTp::ContactsModel)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- sometimes there are no contacts on load</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">more problems: double clicking a person no longer opens the chat.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Also this code has proved too difficult to fix in two hours.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If we can't fix this simply (and we both spent an hour on this) it is clearly way too difficult to maintain, and I'm not going to merge it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Possible solution; move the two models to k-c-i. Put ContcactsRoomsModel as the source of ContactsModel<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
it means you can then kill your sorting code and reduce the complexity a bit.</p></pre>
<br />
<p>- David</p>
<br />
<p>On August 5th, 2014, 1:15 p.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2014, 1:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-contact-list
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The long-awaited Dan-sized patch is here :-)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch merges the KTp::ContactsModel and RoomsModel (simple channel observer) into a single tree model via ContactsRoomsModel. The model now looks like</p>
<table style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<thead style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<tr style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<th style="padding: 0.2em 1em;text-rendering: inherit;white-space: normal;margin: 0;line-height: inherit;border-bottom: 1px solid #bbb;"></th>
</tr>
</thead>
<tbody style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<tr style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<td style="padding: 0.2em 1em;text-rendering: inherit;white-space: normal;margin: 0;line-height: inherit;border-bottom: 1px solid #bbb;"></td>
</tr>
<tr style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<td style="padding: 0.2em 1em;text-rendering: inherit;white-space: normal;margin: 0;line-height: inherit;border-bottom: 1px solid #bbb;"></td>
</tr>
<tr style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<td style="padding: 0.2em 1em;text-rendering: inherit;white-space: normal;margin: 0;line-height: inherit;border-bottom: 1px solid #bbb;">- Contacts</td>
</tr>
<tr style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<td style="padding: 0.2em 1em;text-rendering: inherit;white-space: normal;margin: 0;line-height: inherit;border-bottom: 1px solid #bbb;">- Group 1</td>
</tr>
<tr style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<td style="padding: 0.2em 1em;text-rendering: inherit;white-space: normal;margin: 0;line-height: inherit;border-bottom: 1px solid #bbb;"></td>
</tr>
<tr style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<td style="padding: 0.2em 1em;text-rendering: inherit;white-space: normal;margin: 0;line-height: inherit;border-bottom: 1px solid #bbb;"></td>
</tr>
<tr style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<td style="padding: 0.2em 1em;text-rendering: inherit;white-space: normal;margin: 0;line-height: inherit;border-bottom: 1px solid #bbb;">- Group 2</td>
</tr>
</tbody>
</table>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">After a few beers, I was even able to make my model work with David's EmptyRowFilter, so the "Chat rooms" (or "Contacts") top-level nodes will be automatically hidden, when they have no children</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch is so big, because I refactored the delegates a little, but other than that, it's just the two new models and small changes in context menu and contact overlays to support rooms.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unfortunately this patch causes ktp-contact-list to crash when switching from "Do not show groups" to "Show contacts by groups". Interestingly, it does not crash when switching the other way around. I'm completely clueless, so if you guys can figure something out, it would me much appreciated. This patch cannot go in until the crash is fixed of course.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Joined a room, room immediately appeared in the CL. Closed text-ui, room remained in CL. Clicked the room in CL, text-ui was started again. Left the room, it disappeared from CL.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contact-list-widget.cpp <span style="color: grey">(3ffa1cc)</span></li>
<li>contact-list-widget_p.h <span style="color: grey">(e4a5eb3)</span></li>
<li>contact-overlays.h <span style="color: grey">(a998644)</span></li>
<li>contact-overlays.cpp <span style="color: grey">(ee14e8f)</span></li>
<li>contacts-rooms-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>contacts-rooms-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>context-menu.h <span style="color: grey">(bec4e55)</span></li>
<li>context-menu.cpp <span style="color: grey">(00795d7)</span></li>
<li>empty-row-filter.cpp <span style="color: grey">(01b2b48)</span></li>
<li>main-widget.cpp <span style="color: grey">(cf1b97d)</span></li>
<li>rooms-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>rooms-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tooltips/tooltipmanager.cpp <span style="color: grey">(555d425)</span></li>
<li>CMakeLists.txt <span style="color: grey">(1ee112a)</span></li>
<li>abstract-contact-delegate.h <span style="color: grey">(2339833)</span></li>
<li>abstract-contact-delegate.cpp <span style="color: grey">(a92cc4e)</span></li>
<li>contact-delegate-compact.h <span style="color: grey">(736d2e5)</span></li>
<li>contact-delegate-compact.cpp <span style="color: grey">(c51a210)</span></li>
<li>contact-delegate.h <span style="color: grey">(9f0e5df)</span></li>
<li>contact-delegate.cpp <span style="color: grey">(537e204)</span></li>
<li>contact-list-widget.h <span style="color: grey">(8f39b81)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118237/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/21/09b64e1d-7c31-4fc1-a3ff-08996fcd930d__ktp-cl.png">Screenshot</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/21/b6bf32cb-3e65-47e3-af15-5859e2dbdda5__ktp-cl.png">Screenshot with contact groups enabled</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>