<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119467/">https://git.reviewboard.kde.org/r/119467/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 4th, 2014, 9:51 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119467/diff/2/?file=294974#file294974line679" style="color: black; font-weight: bold; text-decoration: underline;">src/call-window.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">619</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">qmlUi</span><span class="o">-></span><span class="n">setWindowFlags</span><span class="p">(</span><span class="n">Qt</span><span class="o">::</span><span class="n">Widget</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">620</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setCentralWidget</span><span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">qmlUi</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Are these really needed? The docs are not explicit on this after showFullScreen() has been called, but maybe just showNormal() would be enough?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think when i did this it was impossible to make the central widget go to fullscreen if it wasn't an independent window. That's why i need to restart the flags like that. <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I don't really know if that makes sense.</p></pre>
<br />
<p>- Ekaitz</p>
<br />
<p>On August 2nd, 2014, 11:28 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Aug. 2, 2014, 11:28 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-call-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Implement the main UI in QML (Kadixt patches 1/3)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Rebased, patched and cherry-picked until I was red in the face.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles, not tested beyond that.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8c39e7c)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(250aeb5)</span></li>
<li>src/call-window.h <span style="color: grey">(07fd01e)</span></li>
<li>src/call-window.cpp <span style="color: grey">(c38112d)</span></li>
<li>src/call-window.ui <span style="color: grey">(32c7dad)</span></li>
<li>src/callwindowui.rc <span style="color: grey">(6c390b9)</span></li>
<li>src/dtmf-handler.h <span style="color: grey">(91960dc)</span></li>
<li>src/dtmf-handler.cpp <span style="color: grey">(d8d7970)</span></li>
<li>src/dtmf-qml.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/dtmf-qml.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/dtmf-widget.h <span style="color: grey">(9e1bc73)</span></li>
<li>src/dtmf-widget.cpp <span style="color: grey">(f3436b2)</span></li>
<li>src/dtmf-widget.ui <span style="color: grey">(67f60b9)</span></li>
<li>src/qml-interface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml-interface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/Main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/core/Button.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/core/Dtmf.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/core/DtmfButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/core/Label.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/core/Separator.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/core/ToggleButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/core/Toolbar.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/core/Tooltip.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119467/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>