<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119086/">https://git.reviewboard.kde.org/r/119086/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The TPLQT_TPL_IS_VERSION macro is defined in log-manager.h, which is public, so you can safely use it here too. Just do something like</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #BC7A00">#if TPLQT_TPL_IS_VERSION(0, 9, 0)</span>
code
<span style="color: #BC7A00">#else</span>
<span style="color: #008000; font-weight: bold">return</span> defualtValue;
<span style="color: #BC7A00">#endif</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In all three TpLoggerPlugin methods implementations.</p></pre>
<br />
<p>- Dan Vrátil</p>
<br />
<p>On July 7th, 2014, 7:37 p.m. CEST, Marcin Ziemiński wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Marcin Ziemiński.</div>
<p style="color: grey;"><i>Updated July 7, 2014, 7:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added an option to disable or enable logging for entities with an implementation in tp-logger-plugin. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Logger/plugins/tplogger/tp-logger-plugin.cpp <span style="color: grey">(8c0cb16)</span></li>
<li>KTp/Logger/abstract-logger-plugin.h <span style="color: grey">(6db98d4)</span></li>
<li>KTp/Logger/abstract-logger-plugin.cpp <span style="color: grey">(6d387bb)</span></li>
<li>KTp/Logger/log-manager.h <span style="color: grey">(c5f92d6)</span></li>
<li>KTp/Logger/log-manager.cpp <span style="color: grey">(7ce4a12)</span></li>
<li>KTp/Logger/plugins/tplogger/tp-logger-plugin.h <span style="color: grey">(346c233)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119086/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>