<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119085/">https://git.reviewboard.kde.org/r/119085/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Marcin Ziemiński.</div>
<p style="color: grey;"><i>Updated July 3, 2014, 8:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added ifdef on version of telepathy-logger. Not sure if this solution is the right way, because I couldn't find anything else. Another approach I can see is doing the evaluation of __TPL_VERSION_DISABLE_LOGGING__ strictly in cmake files to provide only this definition.
Then it could be also added to the related projects such as ktp-common-internals (#119086).
Maybe simply bumping the version of telepathy-logger in CMakeLists is better? </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
telepathy-logger-qt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added simple wrappers of functions available in the master branch of telepathy-logger</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindTelepathyLogger.cmake <span style="color: grey">(19de2e3)</span></li>
<li>TelepathyLoggerQt4/log-manager.cpp <span style="color: grey">(7aadc4d)</span></li>
<li>CMakeLists.txt <span style="color: grey">(db1da08)</span></li>
<li>TelepathyLoggerQt4/log-manager.h <span style="color: grey">(60a0e8c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119085/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>