<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118237/">https://git.reviewboard.kde.org/r/118237/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated May 21, 2014, 1:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-contact-list
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The long-awaited Dan-sized patch is here :-)
This patch merges the KTp::ContactsModel and RoomsModel (simple channel observer) into a single tree model via ContactsRoomsModel. The model now looks like
|
|- Chat rooms
| |- room1@conf.kdetalk.net
| |- room2@conf.kdetalk.net
|- Contacts
|- Group 1
| |- Contact 1
| |- Contact 2
|- Group 2
After a few beers, I was even able to make my model work with David's EmptyRowFilter, so the "Chat rooms" (or "Contacts") top-level nodes will be automatically hidden, when they have no children
The patch is so big, because I refactored the delegates a little, but other than that, it's just the two new models and small changes in context menu and contact overlays to support rooms.
Unfortunately this patch causes ktp-contact-list to crash when switching from "Do not show groups" to "Show contacts by groups". Interestingly, it does not crash when switching the other way around. I'm completely clueless, so if you guys can figure something out, it would me much appreciated. This patch cannot go in until the crash is fixed of course.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Joined a room, room immediately appeared in the CL. Closed text-ui, room remained in CL. Clicked the room in CL, text-ui was started again. Left the room, it disappeared from CL.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1ee112a)</span></li>
<li>abstract-contact-delegate.h <span style="color: grey">(2339833)</span></li>
<li>abstract-contact-delegate.cpp <span style="color: grey">(a92cc4e)</span></li>
<li>contact-delegate-compact.h <span style="color: grey">(736d2e5)</span></li>
<li>contact-delegate-compact.cpp <span style="color: grey">(c51a210)</span></li>
<li>contact-delegate.h <span style="color: grey">(9f0e5df)</span></li>
<li>contact-delegate.cpp <span style="color: grey">(537e204)</span></li>
<li>contact-list-widget.h <span style="color: grey">(8f39b81)</span></li>
<li>contact-list-widget.cpp <span style="color: grey">(3ffa1cc)</span></li>
<li>contact-list-widget_p.h <span style="color: grey">(e4a5eb3)</span></li>
<li>contact-overlays.h <span style="color: grey">(a998644)</span></li>
<li>contact-overlays.cpp <span style="color: grey">(ee14e8f)</span></li>
<li>contacts-rooms-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>contacts-rooms-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>context-menu.h <span style="color: grey">(bec4e55)</span></li>
<li>context-menu.cpp <span style="color: grey">(00795d7)</span></li>
<li>empty-row-filter.cpp <span style="color: grey">(01b2b48)</span></li>
<li>main-widget.cpp <span style="color: grey">(a07b534)</span></li>
<li>rooms-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>rooms-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tooltips/tooltipmanager.cpp <span style="color: grey">(555d425)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118237/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/21/09b64e1d-7c31-4fc1-a3ff-08996fcd930d__ktp-cl.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>