<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117543/">https://git.reviewboard.kde.org/r/117543/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated April 17, 2014, 3:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As David suggested, we now only keep the channels in TelepathyChatUi when they don't have any tab assigned. This also fixes duplicated notifications, reconnection and makes the code cleaner.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When "Don't leave chat room when window is closed" settings is enabled, the channel is not closed when user closes the tab or window, but is maintained by TelepathyChatUi. The channel can be left via Conversation -> Leave room action.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-tab.h <span style="color: grey">(0bb9dcf)</span></li>
<li>app/chat-tab.cpp <span style="color: grey">(5c9308a)</span></li>
<li>app/chat-window.h <span style="color: grey">(72bbd1d)</span></li>
<li>app/chat-window.cpp <span style="color: grey">(a7da574)</span></li>
<li>app/telepathy-chat-ui.h <span style="color: grey">(97bc4b7)</span></li>
<li>app/telepathy-chat-ui.cpp <span style="color: grey">(33150b8)</span></li>
<li>config/behavior-config.h <span style="color: grey">(d57fd90)</span></li>
<li>config/behavior-config.cpp <span style="color: grey">(eeb3597)</span></li>
<li>config/behavior-config.ui <span style="color: grey">(c8e731c)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(3929e45)</span></li>
<li>lib/notify-filter.h <span style="color: grey">(f929ce3)</span></li>
<li>lib/notify-filter.cpp <span style="color: grey">(6807dac)</span></li>
<li>lib/text-chat-config.h <span style="color: grey">(e0ba24f)</span></li>
<li>lib/text-chat-config.cpp <span style="color: grey">(57c7c0c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117543/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>