<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117579/">https://git.reviewboard.kde.org/r/117579/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Diane Trout.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkpeople
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When submitting libkpeople to debian Sune Vuorela wanted me to adjust library version number so it starts with SONUMBER. The vast majority of shared libraries on Linux conform to the convention that libfoo.so.3 -> libfoo.so.3.4.5. The clearest documenation of the convention I could find was here: http://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html
I had considered using the pattern libfoo.so.3.$(package_version) AKA something like libfoo.so.3.0.2.1 but 4 digits is also a bit unusual. I decided that its ok if the major package version number and so version number differ as they are referencing different concepts package stability vs API version. However the minor and patch versions would tend to get incremented for the package and the library with roughly the same meaning (minor API compatible changes).
I can imagine 4 reasonably sane conventions.
1) library version number has nothing to do with the product version.
2) library version number is soversion+major+minor+patch.
3) library version number is soversion+minor+patch.
4) library version number is soversion+major+minor.
My first fix was #2, this version is #3. I don't really care which version works best.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Applied patch. mkdir build ; cd build ; cmake .. ; find . -name "*.so" make sure the libkpeople.so.3 -> libkpeople.so.3.2.1</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgets/CMakeLists.txt <span style="color: grey">(8be6331)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(a04c332)</span></li>
<li>CMakeLists.txt <span style="color: grey">(5ee7c9d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117579/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>