<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117541/">https://git.reviewboard.kde.org/r/117541/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 16th, 2014, 8:41 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/117541/file/1209/" style="color: black; font-weight: bold; font-size: 9pt;">snapshot147.png</a>
<p>Previous tab</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wouldn't release it like that. It makes it look like one could join several rooms at once by ticking their checkboxes and then clicking "Join/Create", which isn't the case.
If the checkbox cannot be hidden, I recommend using a table view and naming the columns "Favorite" (or using the star as the name if possible) and "Name", and not showing the stars in the actual table at all.</pre>
</blockquote>
<p>On April 16th, 2014, 10:50 a.m. UTC, <b>Daniele E. Domenichelli</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Martin will fix the checkbox, and replace it with a star, right? :D</pre>
</blockquote>
<p>On April 16th, 2014, 11:51 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If he does fix it, then I'm fine with it. If it turns out he can't we should come up with a plan B before release.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Plan B: I hit Martin
Plan C: We hide the column
</pre>
<br />
<p>- David</p>
<br />
<p>On April 16th, 2014, 8:26 a.m. UTC, Daniele E. Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniele E. Domenichelli.</div>
<p style="color: grey;"><i>Updated April 16, 2014, 8:26 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Restructure Join Chat Dialog</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8d4ea594e967ef7e26eda6b2ac040a314bb34543)</span></li>
<li>KTp/Models/rooms-model.h <span style="color: grey">(2ff16043a04bae061f12c5780d22c956e7eced82)</span></li>
<li>KTp/Models/rooms-model.cpp <span style="color: grey">(3291b58667d4d5cdfb1acc728dbcb75bc1480e6e)</span></li>
<li>KTp/Widgets/join-chat-room-dialog.h <span style="color: grey">(80a1be33758f6d4bc5c2d65855769aa268827d47)</span></li>
<li>KTp/Widgets/join-chat-room-dialog.cpp <span style="color: grey">(9d55bd9e59b6640748b1fefb7d03040c37e7d092)</span></li>
<li>KTp/Widgets/join-chat-room-dialog.ui <span style="color: grey">(ca72088312862d6a1016f15f5da1485633b6cac9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117541/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/04/16/1d9c1427-09b1-4e18-89bb-f6e12957d4d7__snapshot147.png">Previous tab</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/04/16/ba5f9862-846c-41bb-8e02-5af8be58c0c8__snapshot148.png">Search tab</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>