<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117573/">https://git.reviewboard.kde.org/r/117573/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 15th, 2014, 9:29 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can only see one selectbox to choose the image sharing service in the configuration. What if people simply don't want this feature enabled at all?</pre>
</blockquote>
<p>On April 15th, 2014, 12:05 p.m. UTC, <b>Ahmed Ibrahim</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isn't that the purpose of David's suggestion about the context menu appearing when dropping an image ? If the user does not want to share image he can choose the file transfer option.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These are two different things: One is a decision on a case-by-case basis, the other is a general decision. If a user simply doesn't want to share images publicly on the web, that user should have the ability to switch the feature off instead of having to choose "send image directly" each time they drag an image into a chat.
Maybe we can have an element "Do not use image sharing" in the select box and default to that, and as long as this element is selected, do not show the menu but always send file directly?</pre>
<br />
<p>- Thomas</p>
<br />
<p>On April 14th, 2014, 11:18 p.m. UTC, Ahmed Ibrahim wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Ahmed Ibrahim.</div>
<p style="color: grey;"><i>Updated April 14, 2014, 11:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=322874">322874</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've wrote an extensible image sharer library that can upload images to Imgur, Simplest Image Host and ImageBin, the library can be extended to support other services like wstaw.org for example. I've integrated the library with text-ui and used it to share images to the choosed service when dragging it to the text-ui.
I've added a new "Image Sharing" configuration item under the Chat Tab Behaviour, you will find the screenshot attached.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dragged an image to the text-ui and the image url is appended and sent to the other endpoint of the conversation.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(eabecd9)</span></li>
<li>config/CMakeLists.txt <span style="color: grey">(a8e7cd9)</span></li>
<li>config/behavior-config.h <span style="color: grey">(d57fd90)</span></li>
<li>config/behavior-config.cpp <span style="color: grey">(eeb3597)</span></li>
<li>config/behavior-config.ui <span style="color: grey">(c8e731c)</span></li>
<li>image-sharer/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/abstractsharer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/abstractsharer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/cmake/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/cmake/modules/FindQJson.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/imagebinsharer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/imagebinsharer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/imagesharer_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/imgursharer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/imgursharer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/mpform.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/mpform.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/shareprovider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/shareprovider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/simplestimagehostingsharer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>image-sharer/simplestimagehostingsharer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(d640536)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(d9c4e60)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(d130529)</span></li>
<li>lib/text-chat-config.h <span style="color: grey">(e0ba24f)</span></li>
<li>lib/text-chat-config.cpp <span style="color: grey">(57c7c0c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117573/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/04/14/1a00a5d6-dd2e-4b58-a25b-c456d4adc89e__ktp-text-ui-share.png">A screenshot of an uploaded image to the three supported image sharing services </a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/04/14/546bdac8-a803-48ac-a79c-0b5a8ba2a392__snapshot4.png">Image Sharing Settings under the Chat Tab Behaviour</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>