<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117570/">https://git.reviewboard.kde.org/r/117570/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 14th, 2014, 11:39 p.m. UTC, <b>Daniele E. Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/117570/diff/1/?file=266039#file266039line151" style="color: black; font-weight: bold; text-decoration: underline;">lib/chat-widget.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">protected Q_SLOTS:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">151</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">onParticipantsChanged</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">151</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">onParticipantsChanged</span><span class="p">(</span><span class="n"><span class="hl">Tp</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">Contacts</span></span><span class="hl"> </span><span class="n"><span class="hl">contactsJoined</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since you are changing this, perhaps you could make it with the same signature as Tp::Channel::groupMembersChanged http://telepathy.freedesktop.org/doc/telepathy-qt/a00106.html#a9a19634088f78c3fb81fd166df72739e , it will be easier in the future if we want to support the part/quit/kick/ban messages. (Also perhaps using groupLocalPendingMembersAdded and groupRemotePendingMembersAdded it could be possible to show contacts invited that did not accept the invitation yet? Anyway that's for some future patch)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From what I could tell group*PendingMembersAdded was never called. I was trying to solve exactly what you just suggested :)</pre>
<br />
<p>- David</p>
<br />
<p>On April 14th, 2014, 8:02 p.m. UTC, Daniel Cohen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniel Cohen.</div>
<p style="color: grey;"><i>Updated April 14, 2014, 8:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added join message capability. Configuration of displaying it is tied in with the option for showing people leaving.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Joined and left with several accounts into a chat room.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config/appearance-config-tab.h <span style="color: grey">(9582660)</span></li>
<li>config/appearance-config-tab.cpp <span style="color: grey">(f8314d8)</span></li>
<li>config/appearance-config.ui <span style="color: grey">(6440cba)</span></li>
<li>lib/adium-theme-view.h <span style="color: grey">(5eaab55)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(e0ad0b1)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(5428104)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(3929e45)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117570/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>