<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117534/">https://git.reviewboard.kde.org/r/117534/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds persist bool argument to ctors of TelepathyHandlerApplication, which allows applications to force the persistent mode (like passing --persist to command line). This is needed for ktp-text-ui in order to stay alive and keep group chats channels opened even when all windows are closed.
Secondly, this patch makes THA actually persist even when last window is closed. This is because each KMainWindow holds one KGlobal reference and KGlobal::deref() will call QApplication::quit() regardless of setQuitOnLastWindowClosed(). To prevent this from happening, THA is now holding one reference indefinitely, which means that the application can only be terminated by an explicit call to QApplication::quit() from the application itself.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/telepathy-handler-application.h <span style="color: grey">(fbdb523)</span></li>
<li>KTp/telepathy-handler-application.cpp <span style="color: grey">(2b5d608)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117534/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>