<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114574/">https://git.reviewboard.kde.org/r/114574/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 24th, 2014, 10:30 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch. Unfortunately I don't think this patch has a place in KTp. I can see many scenarios where people's laptops won't suspend unexpectedly, possibly burning down in their bags while running for the bus, resulting in angry (KDE) users. If you want to disable suspending/power management, there's already a checkbox for that in the battery plasmoid, which does precisely this. I don't want to have duplicated functionality around the system hidden in a user application that virtually all users would never think of being the cause of their broken suspend. Sorry.
I hate to trash the code and work that went into it; it helps if you talk to us about your ideas first :)</pre>
</blockquote>
<p>On March 25th, 2014, 2:32 a.m. UTC, <b>James Smith</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Lid switch and manual power events override custom application suspend inhibition. It's also just as simple to make certain to set Ktp off-line or change the settings in order to not inhibit suspend while hovering in a certain presence, or, keep it completely disabled.
The only usable purpose would be to avoid missing incoming calls while away from the machine.
I also forget most times about the battery monitor suspend switch, and dislike having to reset it after disabling, so most of the time I return to a sleeping or turned off machine.
Thanks!</pre>
</blockquote>
<p>On March 25th, 2014, 11:38 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"It's also just as simple to make certain to set Ktp off-line or change the settings in order to not inhibit suspend while hovering in a certain presence"
Which is precisely what you can do with that PM checkbox, these would just be the exact same setting masked in a client application in another place. And actually it's just two clicks if your panel is not auto-hidden and your battery plasmoid is not autohidden (which they are not by default), plus setting yourself offline just to let the auto suspend work breaks "restore presence on resume from suspend", because it would restore you to offline. Setting your presence to anything but online and offline in order to enable auto suspend is just wrong.
"The only usable purpose would be to avoid missing incoming calls while away from the machine."
I'm sorry but this is not strong enough use case for this change (especially in the light of the battery checkbox existing and doing precisely that; it was meant to do that).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We should certainly have something like this when in a call that for sure.
When on idle I think we have to suspend by default, I understand why this patch would be desirable but we need something like what iOS or Android does where they suspend most of the system but the services dedicated to receive calls and the like.</pre>
<br />
<p>- Àlex</p>
<br />
<p>On March 23rd, 2014, 8:28 a.m. UTC, James Smith wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Àlex Fiestas.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated March 23, 2014, 8:28 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-kded-module
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KeepAwake plugin inhibits suspend for certain IM states. Also adds infrastructure for presence-responsive plugins.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compile, runtime.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d08606b)</span></li>
<li>config/telepathy-kded-config.cpp <span style="color: grey">(baaceff)</span></li>
<li>config/telepathy-kded-config.h <span style="color: grey">(0400626)</span></li>
<li>config/telepathy-kded-config.ui <span style="color: grey">(18f06f3)</span></li>
<li>keepawake.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>keepawake.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>telepathy-module.h <span style="color: grey">(2213cdf)</span></li>
<li>telepathy-module.cpp <span style="color: grey">(030a0d9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114574/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>