<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117329/">https://git.reviewboard.kde.org/r/117329/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 139e22761c2511906435b0e8149354ff8750d6e1 by David Edmundson to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On April 2nd, 2014, 11:08 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated April 2, 2014, 11:08 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-kded-module
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Split presence handling into a new class. Code is a direct copy/paste from telepathy-module (changes to that should happen in later commits)
Add small app for running the status handling of the kded
Rather than restarting kded all the time developers can run the small test app to check the status handling.
Should be possible to turn this into a proper unit test at some point in the near future later.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d08606b)</span></li>
<li>status-handler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>status-handler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>telepathy-module.h <span style="color: grey">(2213cdf)</span></li>
<li>telepathy-module.cpp <span style="color: grey">(030a0d9)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(7696369)</span></li>
<li>tests/status-handling-main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117329/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>