<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116774/">https://git.reviewboard.kde.org/r/116774/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 24th, 2014, 6:02 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for the delay. I was on vacation.
Long term I think I want a visual cue inside the chat tab. Otherwise the behaviour might just seem erratic, also I'd like to have save/restore per contact when starting a chat with a known contact.
The code itself seems pretty rock solid. Thanks.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree that a visual indicator of the layot used per tab would be important for those using this feature. On the other hand, though, it would be useless visual noise for those - presumably the majority of users - who don't switch the layout. Maybe it could be only shown if users actually have several layouts active, or follow the visibility of the layout switcher in the systray?</pre>
<br />
<p>- Thomas</p>
<br />
<p>On March 12th, 2014, 11:04 p.m. UTC, Ahmed Ibrahim wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Ahmed Ibrahim.</div>
<p style="color: grey;"><i>Updated March 12, 2014, 11:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=308953">308953</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used DBus interface to switch the keyboard layout and listen to the keyboard layout change. Stored the language in each ChatTab instance and then restore it back when the ChatWindow is activated and when switching between tabs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opened multiple ChatTabs and changed language of each one of them. When Switching between the tabs the language indicator is changed according to the language that is stored in the ChatTab.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-window.h <span style="color: grey">(793ac55)</span></li>
<li>app/chat-window.cpp <span style="color: grey">(2c2e12b)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(c1dbd41)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(e7c7619)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116774/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>