<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116706/">https://git.reviewboard.kde.org/r/116706/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 24th, 2014, 5:31 p.m. YEKT, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">/home/david/projects/kde4/src/ktp-common-internals/kpeople/datasourceplugin/im-persons-data-source.cpp:124:33: error: use of undeclared identifier 'contactGroups'
addressee.setCategories(contactGroups);
^
/home/david/projects/kde4/src/ktp-common-internals/kpeople/datasourceplugin/im-persons-data-source.cpp:117:48: warning: comparison of integers of different signs: 'uint' (aka 'unsigned int') and 'int' [-Wsign-compare]
if ((!convSuccess) || (groupId >= groupsList.count()))
~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
kpeople/datasourceplugin/CMakeFiles/im_persons_data_source_plugin.dir/build.make:80: recipe for target 'kpeople/datasourceplugin/CMakeFiles/im_persons_data_source_plugin.dir/im-persons-data-source.cpp.o' failed
make[2]: *** [kpeople/datasourceplugin/CMakeFiles/im_persons_data_source_plugin.dir/im-persons-data-source.cpp.o] Error 1
CMakeFiles/Makefile2:224: recipe for target 'kpeople/datasourceplugin/CMakeFiles/im_persons_data_source_plugin.dir/all' failed
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Excuse me! I has playing with QtCreator thus much, so needed to remove profile. After it, I forget to setup some autosave function.</pre>
<br />
<p>- Alexandr</p>
<br />
<p>On March 14th, 2014, 4:56 p.m. YEKT, Alexandr Akulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Alexandr Akulich.</div>
<p style="color: grey;"><i>Updated March 14, 2014, 4:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=331272">331272</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implemented groups cache support.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works as expected, but ktp-kded-module patch needed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kpeople/datasourceplugin/im-persons-data-source.cpp <span style="color: grey">(94d8de1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116706/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>