<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115618/">https://git.reviewboard.kde.org/r/115618/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- David Edmundson</p>
<br />
<p>On February 10th, 2014, 10:19 a.m. UTC, Alexandr Akulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Alexandr Akulich.</div>
<p style="color: grey;"><i>Updated Feb. 10, 2014, 10:19 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-kded-module
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manually constructed factories and managers replaced by KTp ones.
Such change let us to cleanup code and let freely use KTp methods without dbus traffic duplication (which is occurs in last commit).
As according things:
Reworked includes.
Fixed a lot of coding style issues.
ContactNotify: Removed "using namespace KTp" from header.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled successfully. Seems to work, but not tested a lot.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>error-handler.cpp <span style="color: grey">(2b84784)</span></li>
<li>screensaveraway.cpp <span style="color: grey">(6c47cfb)</span></li>
<li>telepathy-kded-module-plugin.cpp <span style="color: grey">(43cb383)</span></li>
<li>telepathy-module.h <span style="color: grey">(ec08c6e)</span></li>
<li>telepathy-module.cpp <span style="color: grey">(bf154c6)</span></li>
<li>telepathy-mpris.cpp <span style="color: grey">(1c7b98c)</span></li>
<li>autoaway.h <span style="color: grey">(ac42718)</span></li>
<li>autoaway.cpp <span style="color: grey">(79f62f0)</span></li>
<li>autoconnect.h <span style="color: grey">(aeb4b54)</span></li>
<li>autoconnect.cpp <span style="color: grey">(b779426)</span></li>
<li>contact-request-handler.h <span style="color: grey">(69d2a1e)</span></li>
<li>contact-request-handler.cpp <span style="color: grey">(1b13194)</span></li>
<li>contactnotify.h <span style="color: grey">(4dc71e4)</span></li>
<li>contactnotify.cpp <span style="color: grey">(9f001f4)</span></li>
<li>error-handler.h <span style="color: grey">(dd62822)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115618/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>