<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115463/">https://git.reviewboard.kde.org/r/115463/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 5th, 2014, 5:33 p.m. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115463/diff/5/?file=242101#file242101line1810" style="color: black; font-weight: bold; text-decoration: underline;">data/ktelepathy.notifyrc</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1810</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Name=Send exe or ini files via GoogleTalk</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The wording should imho be "Sending exe or ini...", simillarily the comment should explain the user what this notification is for, so I'd suggest something like "Informs that the file sent was renamed because GoogleTalk (should be just Google? Gmail is blocked too) blocks some extensions"</pre>
</blockquote>
<p>On February 5th, 2014, 10:24 p.m. CET, <b>Jan Stourac</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">suggestions:
Configuration dialog - title: GoogleTalk file renamed
Configuration dialog - description: An outgoing file with forbidden extension .exe or .ini has been renamed.
Notification - title: Attention: Transferred file renamed
Notification - message: Transferring files with .exe or .ini extension is not allowed by GoogleTalk. Your file was renamed to <i>%1</i>.
and i prefer to keep GoogleTalk, because i think that "Gmail chat" == GoogleTalk and limitations of Gmail email are not our bussiness?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Configuration dialog - title: GoogleTalk file renamed
"File renamed for sending with Google Talk"...our strings can be less techy :)
> Notification - title: Attention: Transferred file renamed
(Popup) notification itself means "attention", so let's remove that.
> Notification - message: Transferring files with .exe or .ini extension is not allowed by GoogleTalk. Your file was renamed to <i>%1</i>.
The last part indicates that the file on the disk was renamed rather than the sent one, which is not true (right?). So something like "It was sent with filename %1".
>...keep GoogleTalk
My point was that there is no Google Talk (also it has space in the name), it's called Hangouts now and it's general Google limitation (it would fit better in the original sentence), but meh...we actually still implement the old Talk interface, so let's stick with that.</pre>
<br />
<p>- Martin</p>
<br />
<p>On February 5th, 2014, 5:29 p.m. CET, Jan Stourac wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Jan Stourac.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2014, 5:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=326786">326786</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">each file transfer is checked for using google talk and forbidden extensions...in that case, "_" character is appended to suggested file name. for all other cases, transfer process remains the same.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/actions.cpp <span style="color: grey">(ec8a19e)</span></li>
<li>data/ktelepathy.notifyrc <span style="color: grey">(1d2411d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115463/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>