<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115076/">https://git.reviewboard.kde.org/r/115076/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 18th, 2014, 1:20 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/115076/file/990/" style="color: black; font-weight: bold; font-size: 9pt;">kcm.png</a>
<p>kcm.png</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure if duplicating this is a good idea...the rest yes, this button, not so sure.</pre>
</blockquote>
<p>On January 18th, 2014, 1:43 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Genereally I don't think duplicating things is a problem. What might be a problem here is that users might have difficulties finding the regular Add Account button afterwards because they keep looking for it somewhere in the accounts list. With QML, we could just put a big red arrow pointing to the button in there instead of the duplicate button, but it might be difficult with widgets...</pre>
</blockquote>
<p>On January 18th, 2014, 1:54 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well you can just say "click the button on the right" ;)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You could put that, till it gets translated into Arabic.
Personally I like the idea of being vaguely consistent with BlueDevil, WebAccounts and the printer one.
I might even try and get this into ItemViews in Frameworks?</pre>
<br />
<p>- David</p>
<br />
<p>On January 17th, 2014, 2:56 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2014, 2:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-accounts-kcm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Display nice UI when no accounts are present, see screenshot</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(cf7998e)</span></li>
<li>src/accounts-list-view.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/accounts-list-view.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcm-telepathy-accounts.cpp <span style="color: grey">(c8b837b)</span></li>
<li>src/main-widget.ui <span style="color: grey">(4983c71)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115076/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/17/2880d55c-2c75-4706-9694-ef25fdd92f47__kcm.png">kcm.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>