<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114275/">https://git.reviewboard.kde.org/r/114275/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ed1b73c4d893f2eaaab423e9c736127e1431399c by David Edmundson to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On December 3rd, 2013, 3:37 p.m. UTC, Giuseppe Calà wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Giuseppe Calà.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2013, 3:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First of all, two assumptions:
1. I know that this code should be supplied upstream to kdelibs but ktp-text-ui's code is smaller and easier, for me, to manage.
2. This patch tries to fix what in my opinion is an usability issue.
Ktp-text-ui uses a QHash from KEmoticonsTheme::emoticonsMap() to build emoticons' QListWidget. The problem is that items in a QHash are arbitrarily ordered so the resulting view is messed up. With this patch the returned QHash is instead used to build a QMap, whose elements are ordered by key, and use this one as source for EmoticonTextEditItem. The final result is a view where emoticons are ordered by their filename.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with Google Hangout Emojis Complete theme from kde-look.org:
Before: http://wstaw.org/m/2013/12/03/emoticons-view-before.png
After: http://wstaw.org/m/2013/12/03/emoticons-view-after.png</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/emoticon-text-edit-selector.cpp <span style="color: grey">(1fad99b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114275/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>