<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114121/">https://git.reviewboard.kde.org/r/114121/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Couple comments on the UI itself</pre>
 <br />





<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/114121/file/965/" style="color: black; font-weight: bold; font-size: 9pt;">sipe_sipe.png</a>

   <p>ui</p>



    <div><img src="" width="473" height="53" alt="The checkboxes should have the labels on the right side as per our HIG[1], also so it's easier to toggle the checkbox as you can also click the label

[1] - http://techbase.kde.org/Projects/Usability/HIG/Check_Box (see Appearance)" /></div>


  </td>
 </tr>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The checkboxes should have the labels on the right side as per our HIG[1], also so it's easier to toggle the checkbox as you can also click the label

[1] - http://techbase.kde.org/Projects/Usability/HIG/Check_Box (see Appearance)</pre>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/114121/file/965/" style="color: black; font-weight: bold; font-size: 9pt;">sipe_sipe.png</a>

   <p>ui</p>



    <div><img src="" width="426" height="39" alt="Are there known values for this? If so, we should make it a combobox; same for the auth scheme" /></div>


  </td>
 </tr>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are there known values for this? If so, we should make it a combobox; same for the auth scheme</pre>
<br />





<p>- Martin Klapetek</p>


<br />
<p>On December 31st, 2013, 1:26 p.m. CET, Maksim Melnikau wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Maksim Melnikau.</div>


<p style="color: grey;"><i>Updated Dec. 31, 2013, 1:26 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-accounts-kcm
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">telepathy-sipe e.g. pidgin-sipe telepathy's backend support</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">only basic testing done, not all advanced options tested </pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/CMakeLists.txt <span style="color: grey">(e752ef1)</span></li>

 <li>plugins/sipe/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/sipe/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/sipe/ktpaccountskcm_plugin_sipe.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/sipe/sipe-account-ui-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/sipe/sipe-account-ui-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/sipe/sipe-account-ui.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/sipe/sipe-account-ui.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/sipe/sipe-advanced-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/sipe/sipe-advanced-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/sipe/sipe-advanced-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/sipe/sipe-main-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/sipe/sipe-main-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/sipe/sipe-main-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114121/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>

<ul>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/2d6fe8f2-3913-4884-8e14-e49d8f9b38e0__sipe_sipe.png">ui</a></li>

</ul>





  </td>
 </tr>
</table>








  </div>
 </body>
</html>