<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114527/">https://git.reviewboard.kde.org/r/114527/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6006557489bb5256f6c7a12c101c1894387bc2ca by David Edmundson to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On December 18th, 2013, 3:24 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Dec. 18, 2013, 3:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use singleton factory classes from K-C-I
This delays creating an AccountFactory till it's needed, such as
clicking "invite to chat". AccountManager calls becomeReady
immediately which loaded all accounts when we start.
This approach should reduce DBus traffic and get faster load times
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-window.cpp <span style="color: grey">(3d6ee7d)</span></li>
<li>app/main.cpp <span style="color: grey">(bacd931)</span></li>
<li>app/telepathy-chat-ui.h <span style="color: grey">(735a203)</span></li>
<li>app/telepathy-chat-ui.cpp <span style="color: grey">(b0cf7fc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114527/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>