<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114718/">https://git.reviewboard.kde.org/r/114718/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Leon Handreke.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2013, 1:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove ConversationTarget, put as title/avatar/presenceIcon into Conversation</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested plasmoid, still works fine.
Flipped the if in the Conversation constructor to make the Conversation think that it's a group chat, plasmoid still works (but doesn't show proper name, avatar and presence) and crashes when trying to pin contacts (the "star" button).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Declarative/CMakeLists.txt <span style="color: grey">(5517c31d511e04a0d695290d5044cf16bc958478)</span></li>
<li>KTp/Declarative/conversation-target.h <span style="color: grey">(e620cdc75193e78f31e5d6a8cefb3d8b2a87b6cd)</span></li>
<li>KTp/Declarative/conversation-target.cpp <span style="color: grey">(4e8af19397ec77fecf1a876d7378119204f02932)</span></li>
<li>KTp/Declarative/conversation.h <span style="color: grey">(38b313e700244173e8988e1e65cf48f82e04288b)</span></li>
<li>KTp/Declarative/conversation.cpp <span style="color: grey">(a3644fd6a2726a760ec4dfc3682cd3e93134f00b)</span></li>
<li>KTp/Declarative/conversations-model.cpp <span style="color: grey">(4e3489adc07bc8d724a5456ee371bac32ea4add3)</span></li>
<li>KTp/Declarative/pinned-contacts-model.cpp <span style="color: grey">(ccb5f2d251fb4c4bd7625d9c1ac527f4d1bc64b1)</span></li>
<li>KTp/Declarative/qml-plugins.cpp <span style="color: grey">(88e08bffc75809b3863ac0915c0ef53539c0810f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114718/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>