<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114643/">https://git.reviewboard.kde.org/r/114643/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nicely done. Just couple cosmetic issues</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114643/diff/1/?file=227055#file227055line26" style="color: black; font-weight: bold; text-decoration: underline;">KTp/account-factory.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">Tp</span><span class="o">::</span><span class="n">AccountFactoryPtr</span> <span class="n">KTp</span><span class="o">::</span><span class="n">AccountFactory</span><span class="o">::</span><span class="n">create</span><span class="p">(</span><span class="k">const</span> <span class="n">QDBusConnection</span> <span class="o">&</span><span class="n">bus</span><span class="p">,</span> <span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">Features</span> <span class="o">&</span><span class="n">features</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"{" on a new line</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114643/diff/1/?file=227056#file227056line58" style="color: black; font-weight: bold; text-decoration: underline;">KTp/account-factory_p.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">58</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">static</span> <span class="n">Tp</span><span class="o">::</span><span class="n">AccountPtr</span> <span class="n">create</span> <span class="p">(</span><span class="k">const</span> <span class="n">QDBusConnection</span> <span class="o">&</span><span class="n">bus</span><span class="p">,</span> <span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">busName</span><span class="p">,</span> <span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">objectPath</span><span class="p">,</span> <span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">ConnectionFactoryConstPtr</span> <span class="o">&</span><span class="n">connectionFactory</span><span class="p">,</span> <span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">ChannelFactoryConstPtr</span> <span class="o">&</span><span class="n">channelFactory</span><span class="p">,</span> <span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">ContactFactoryConstPtr</span> <span class="o">&</span><span class="n">contactFactory</span><span class="o">=</span><span class="n">Tp</span><span class="o">::</span><span class="n">ContactFactory</span><span class="o">::</span><span class="n">create</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's an ugly long line, let's trim it with each arg on a new line like the Account just below (same in .cpp)
Oh and space around "=" :P (same in AccountFactory above)</pre>
</div>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On December 24th, 2013, 1:01 p.m. CET, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Dec. 24, 2013, 1:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Set accountUniqueIdentifier on contacts
Tp::Connection has no method to get the holding Tp::AccountPtr
This makes it difficult to work out which account a contact belongs to.
This can't be fixed in TpQt in 0.9.x
Instead create a KTp::Account which sets a property on connection
whenever the connection chanages.
This is exposed from KTp::Contact
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/CMakeLists.txt <span style="color: grey">(29ee1ab)</span></li>
<li>KTp/account-factory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/account-factory_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/contact.h <span style="color: grey">(f33a762)</span></li>
<li>KTp/contact.cpp <span style="color: grey">(52a4f58)</span></li>
<li>KTp/core.cpp <span style="color: grey">(a221e68)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114643/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>