<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114605/">http://git.reviewboard.kde.org/r/114605/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
libkpeople
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add tests for PersonData



Add method to override DataSources used for testing



Remove old nepomuk tests



Add hook to alter the personsDB used

For making unit tests



Remove unused include




---------------

I haven't tested all the things I want; I really want to test the model especially with lots of merging/unmerging
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested my new tests!</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: grey">(43e1008)</span></li>

 <li>src/autotests/fakecontactsource.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/autotests/fakecontactsource.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/autotests/lib/CMakeLists.txt <span style="color: grey">(2358e8b)</span></li>

 <li>src/autotests/lib/NepomukTestLibMacros.cmake.in <span style="color: grey">(5189462)</span></li>

 <li>src/autotests/lib/datagenerator.h <span style="color: grey">(6e75b67)</span></li>

 <li>src/autotests/lib/datagenerator.cpp <span style="color: grey">(630585a)</span></li>

 <li>src/autotests/lib/nepomukserverrc.in <span style="color: grey">(27b5c90)</span></li>

 <li>src/autotests/lib/nepomuktest_export.h <span style="color: grey">(38a8eaa)</span></li>

 <li>src/autotests/lib/testbase.h <span style="color: grey">(6d2a6b3)</span></li>

 <li>src/autotests/lib/testbase.cpp <span style="color: grey">(954fc83)</span></li>

 <li>src/autotests/lib/tools/CMakeLists.txt <span style="color: grey">(2e24962)</span></li>

 <li>src/autotests/lib/tools/dbus-session-begin.sh <span style="color: grey">(ac0e63a)</span></li>

 <li>src/autotests/lib/tools/dbus-session-end.sh <span style="color: grey">(4a13a05)</span></li>

 <li>src/autotests/lib/tools/nepomuk-sandbox-begin.sh.in <span style="color: grey">(a755590)</span></li>

 <li>src/autotests/lib/tools/nepomuk-sandbox-end.sh.in <span style="color: grey">(e331cb0)</span></li>

 <li>src/autotests/lib/tools/runNepomukTest.sh.in <span style="color: grey">(18c73f9)</span></li>

 <li>src/autotests/persondatatests.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/autotests/persondatatests.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/autotests/tests/CMakeLists.txt <span style="color: grey">(63e6739)</span></li>

 <li>src/autotests/tests/duplicatestests.h <span style="color: grey">(2faed15)</span></li>

 <li>src/autotests/tests/duplicatestests.cpp <span style="color: grey">(4083825)</span></li>

 <li>src/autotests/tests/persondatatests.h <span style="color: grey">(90ec2a2)</span></li>

 <li>src/autotests/tests/persondatatests.cpp <span style="color: grey">(bf0c470)</span></li>

 <li>src/personmanager.cpp <span style="color: grey">(fd03ba7)</span></li>

 <li>src/personmanager_p.h <span style="color: grey">(e334f53)</span></li>

 <li>src/personpluginmanager.h <span style="color: grey">(adc7b9d)</span></li>

 <li>src/personpluginmanager.cpp <span style="color: grey">(e433bb5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114605/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>