<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114523/">http://git.reviewboard.kde.org/r/114523/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QSQLITE3 driver shipped with Akonadi is copy (very old one) of upstream QSQLITE driver with some patches for concurrency and we failed to upstream it (it comes from the time before Qt being open governance). Upstreaming the patches is on my TODO, but it's not that simple.
The QSQLITE3 driver should be shipped with Akonadi by default, but it's possible that some distributions split it to separate subpackage, like Fedora does with akonadi-mysql.
You can just use QSQLITE, which is always part of Qt, and just ignore QSQLITE3. You don't need really that level of concurrency in KPeople we need in Akonadi.</pre>
<br />
<p>- Dan Vrátil</p>
<br />
<p>On December 19th, 2013, 6:52 p.m. CET, Alexandr Akulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Alexandr Akulich.</div>
<p style="color: grey;"><i>Updated Dec. 19, 2013, 6:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkpeople
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is said nothing about kpeople dependency on akonadi sqlite driver. At same time, it's said that QMYSQL driver is strongly recommend as Akonadi database backend, so (imo) there is much chance that qsqlite3 driver isn't presented on system, even is akonadi is.
Currently this case isn't handled at all. Library is making visible that all works, while it didn't. E.g. it return "success" result for PersonManager::mergeContacts() and PersonManager::unmergeContact(), even if it fails to update base. It causes strange behavior in clients app.
Proposed change introduce fallback to QSQLITE, as lesser evil.
P.S.: It's hard to understand that QSQLITE3 is correct driver, provided by akonadi. Prefixed with Q instead of K it reject all ideas about kde-relation, while Qt documentation says that driver for SQLite 3 is just "QSQLITE".
If it worth it, may be someone merge changes to upstream "QSQLITE" driver?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All works good without QSQLITE3 driver. I can't find any issues.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/personmanager.cpp <span style="color: grey">(fd03ba7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114523/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>