<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114444/">http://git.reviewboard.kde.org/r/114444/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 16th, 2013, 11:35 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code is fine.
In terms of UI. I don't think it's very clear what this option does. It's obvious if you know about the tab completion, but that's not a very apparent feature.
Thoughts?</pre>
</blockquote>
<p>On December 17th, 2013, 3:01 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Thoughts?
Each UI-related changes should have a screenshot :)
Leon, can you please attach one?</pre>
</blockquote>
<p>On December 18th, 2013, 8:28 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, screenshot(s) please, then I'll review from the usability side as well ;)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What are the other options in the select box?</pre>
<br />
<p>- Thomas</p>
<br />
<p>On December 18th, 2013, 4:14 p.m. UTC, Leon Handreke wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Leon Handreke.</div>
<p style="color: grey;"><i>Updated Dec. 18, 2013, 4:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=326756">326756</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make nick completion style configurable</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Clicked around in the UI, verified that all options work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config/behavior-config.h <span style="color: grey">(fcbdd7f678a8d975751c44afbdcda61771a59f8b)</span></li>
<li>config/behavior-config.cpp <span style="color: grey">(9f863dca930f1b39587fc63207d1c92d096a6559)</span></li>
<li>config/behavior-config.ui <span style="color: grey">(200f6ee4023e11e9101dd10774d8095fab2e0120)</span></li>
<li>lib/chat-text-edit.cpp <span style="color: grey">(4e0f0305b7ae18062f695eb26ee681a0c64aaf26)</span></li>
<li>lib/text-chat-config.h <span style="color: grey">(603c00615d8bd51249ebff4e14fa5b44a2e5af0a)</span></li>
<li>lib/text-chat-config.cpp <span style="color: grey">(7425d5ea03b67022db813c2fffcdcb51c572e759)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114444/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/12/18/98c4ac3e-88ba-4ae9-a9de-14287169fa8d__nickname-completion-screenshot.png">Screenshot of the config UI</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>