<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114366/">http://git.reviewboard.kde.org/r/114366/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 9th, 2013, 5:27 p.m. CET, <b>Dan Vrátil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can optimize the fetchscope of both monitors a little to reduces the amount of data server has to get from database and transmit to client.
m_monitor->itemFetchScope().setFetchModificationTime(false);
m_monitor->itemFetchScope().setFetchRemoteIdentification(false);</pre>
</blockquote>
<p>On December 12th, 2013, 2:35 a.m. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Note that this is (yet-unreleased) 4.12 API. As it was pushed, we must now either make kdepim-libs 4.12 REQUIRED or remove/ifdef those lines, otherwise we're getting build failures with 4.11 kdepim-libs.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only fetchRemoteIdentification(). Sorry for that, being constantly on master I'm losing track of versions and API changes.</pre>
<br />
<p>- Dan</p>
<br />
<p>On December 11th, 2013, 10:57 p.m. CET, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Dan Vrátil.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Dec. 11, 2013, 10:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkpeople
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Share a single Akonadi::Monitor between all AkonadiContact instances
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/akonadi/akonadidatasource.h <span style="color: grey">(b09edf8)</span></li>
<li>src/plugins/akonadi/akonadidatasource.cpp <span style="color: grey">(193de78)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114366/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>