<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113824/">http://git.reviewboard.kde.org/r/113824/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 25th, 2013, 8:43 p.m. YEKT, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113824/diff/4/?file=219593#file219593line31" style="color: black; font-weight: bold; text-decoration: underline;">contact/src/contact-wrapper.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="kt">bool</span> <span class="n">isAccountOnline</span> <span class="n">READ</span> <span class="n">isAccountOnline</span> <span class="n">NOTIFY</span> <span class="n">accountOnlineChanged</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">32</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="kt">bool</span> <span class="n">isContactOnline</span> <span class="n">READ</span> <span class="n">isContactOnline</span> <span class="n">NOTIFY</span> <span class="n">isContactOnlineChanged</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The "isContactOnlineChanged" signal is the same case as the account signal, should be changed too.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh. Ridiculous fault.</pre>
<br />
<p>- Alexandr</p>
<br />
<p>On November 25th, 2013, 5:34 p.m. YEKT, Alexandr Akulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Alexandr Akulich.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2013, 5:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-desktop-applets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">TelepathyContact:
Removed qmlObject related stuff.
m_contact renamed to m_contactWrapper as it should be.
Setup context property before loading qml file.
ContactWrapper:
Properties placed there them should be.
Added property isContactOnline;
Added notifier-signals information for properties.
Property canStartVideo renamed to canStartVideoCall (like canStartAudioCall).
undoAccountConnects() reimplemented to don't break connections possible maked outside.
Same about undoContactConnects().
Methods reordered in cpp file to group simular methods together.
Implemented updateProperties(). In future it's possible to implement granulated properties updating.
Added checks for isAccountOnline in presenceStatus().
Fixed coding-style.
QML part:
Get rid a lot of functions, that anyway doesn't work properly.
Get rid a lot of useless properties.
Don't check avatarPresenceStatus for empty string and don't replace it with default one, because it's already done in c++ part.
Get rid a lot of "anchors.fill: parent" and such, because it's bad practice to let children position itself on parent.
Comminication buttons reordered like in KDE IM Contacts application.
Side effects:
Fixed losted after few went offline/online presenceStatus.
Fixed communication buttons remaining available after account becomes offline.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Plasmoid state properly response on account and/or contact online/offline changing. Contact capabilities showed correctly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contact/src/contact-wrapper.h <span style="color: grey">(7b37907)</span></li>
<li>contact/src/contact-wrapper.cpp <span style="color: grey">(5ef5919)</span></li>
<li>contact/src/declarative/contents/ui/Avatar.qml <span style="color: grey">(6133563)</span></li>
<li>contact/src/declarative/contents/ui/Contact.qml <span style="color: grey">(ab434c8)</span></li>
<li>contact/src/declarative/contents/ui/DropDownMenu.qml <span style="color: grey">(7177c70)</span></li>
<li>contact/src/declarative/contents/ui/main.qml <span style="color: grey">(debb0ed)</span></li>
<li>contact/src/telepathy-contact.h <span style="color: grey">(fe95c83)</span></li>
<li>contact/src/telepathy-contact.cpp <span style="color: grey">(67c8a32)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113824/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>