<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113814/">http://git.reviewboard.kde.org/r/113814/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113814/diff/2/?file=212614#file212614line48" style="color: black; font-weight: bold; text-decoration: underline;">telepathy-kded-module-plugin.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="kt">void</span> <span class="n">reloadConfig</span><span class="p">()</span> <span class="p">{</span> <span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the proper way to do this is
virtual void reloadConfig() = 0;</pre>
</div>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On November 12th, 2013, 10:21 a.m. UTC, Alexandr Akulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Alexandr Akulich.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2013, 10:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-kded-module
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Small refactor of Telepathy KDED Module Plugins.
TelepathyKDEDModulePlugin: Added virtual public slot reloadConfig().
AutoAway: Refactor readConfig() method to reloadConfig() slot.
AutoAway: Get rid onSettingsChanged().
ScreenSaverAway: Refactor readConfig() method to reloadConfig() slot.
ScreenSaverAway: Get rid onSettingsChanged().
TelepathyMPRIS: Rename onSettingsChanged() to reloadConfig().
Module: Connect settingsChanged() to reloadConfig() plugins slot.
Get rid some useless includes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compilation and plugin settings re-applying works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autoaway.h <span style="color: grey">(9496047)</span></li>
<li>autoaway.cpp <span style="color: grey">(ec2afb6)</span></li>
<li>contactnotify.h <span style="color: grey">(e3a5bb6)</span></li>
<li>screensaveraway.h <span style="color: grey">(9332953)</span></li>
<li>screensaveraway.cpp <span style="color: grey">(14f2092)</span></li>
<li>telepathy-kded-module-plugin.h <span style="color: grey">(ac960e2)</span></li>
<li>telepathy-module.cpp <span style="color: grey">(19604bb)</span></li>
<li>telepathy-mpris.h <span style="color: grey">(f9469f1)</span></li>
<li>telepathy-mpris.cpp <span style="color: grey">(a014b51)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113814/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>