<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113448/">http://git.reviewboard.kde.org/r/113448/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 27th, 2013, 7:46 p.m. UTC, <b>Leon Handreke</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113448/diff/1/?file=205949#file205949line26" style="color: black; font-weight: bold; text-decoration: underline;">lib/notify-filter.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">NotifyFilter</span> <span class="o">:</span> <span class="n">public</span> <span class="n">KTp</span><span class="o">::</span><span class="n">AbstractMessageFilter</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">NotifyFilter</span> <span class="o">:</span> <span class="n">public</span> <span class="n">KTp</span><span class="o">::</span><span class="n">AbstractMessageFilter</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do we inherit anything useful from AbstractMessageFilter here?</pre>
</blockquote>
<p>On October 27th, 2013, 8:32 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Legacy :)
To answer your question; it doesn't. Can be made into just a general class or merged into ChatWidget.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added as the second task in http://community.kde.org/KTp/Tasks/TextUIQML.
It may need some further changes, so I'd rather not do it now.</pre>
<br />
<p>- David</p>
<br />
<p>On October 27th, 2013, 12:59 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Oct. 27, 2013, 12:59 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">commit 655de06f7d218109f365bdbeed4c567b63e45376
Author: David Edmundson <kde@davidedmundson.co.uk>
Date: Mon Oct 14 14:14:44 2013 -0700
Fix notifications
commit 28a6ed3b5adcd82449d4e2ee58717ce6b0a27d78
Author: David Edmundson <kde@davidedmundson.co.uk>
Date: Mon Oct 14 18:47:29 2013 +0000
Split message handling out of ChatWidget into MessageView
This prepares it ready for moving to the QML message view
commit 77897b72c6c5ef3a9d4d0c3753b7796cdf24768f
Author: David Edmundson <kde@davidedmundson.co.uk>
Date: Mon Oct 14 18:46:53 2013 +0000
Rename MessageView -> LogMessageView
(it conflicts with a new class I'm about to add)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/CMakeLists.txt <span style="color: grey">(57065228183722b9f5c86ab782a553a4e576c22c)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(c1dbd41456f1bbb9cc1f54743fa6d839d522aec3)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(c2b5a97e739fc78267a243c8e36a9d6efdb98c1c)</span></li>
<li>lib/chat-widget.ui <span style="color: grey">(0985f9c703a2ea34056696fd9265c41432250956)</span></li>
<li>lib/message-view.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/message-view.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/notify-filter.h <span style="color: grey">(f929ce3271bb0d0a98e8aab1b74fd3aee5120c70)</span></li>
<li>lib/notify-filter.cpp <span style="color: grey">(a5c8ba091ade6ece89ec2d3bec2ef24b94cb417f)</span></li>
<li>logviewer/CMakeLists.txt <span style="color: grey">(74989d4596952dd6b790cb5b1a803fd7725efbd3)</span></li>
<li>logviewer/config/behavior-config.cpp <span style="color: grey">(247c03acc706b799cb58213550f4225a24549666)</span></li>
<li>logviewer/log-viewer.ui <span style="color: grey">(cb0a313b5e08e2e265c5c5bf76abf8459639c71f)</span></li>
<li>logviewer/message-view.h <span style="color: grey">(ec592c76f28d7a914808d099febe7ea7eb68ca74)</span></li>
<li>logviewer/message-view.cpp <span style="color: grey">(0b137e10e44d277bda6c525dc48e9c4d5953069e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113448/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>