<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113255/">http://git.reviewboard.kde.org/r/113255/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 376a50dea1dd21220cfcfd078efc04ae47c819e4 by Dan Vrátil to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On October 15th, 2013, 7:11 a.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Oct. 15, 2013, 7:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) When user clicks Action -> Clear View, clear the sent message history in ChatTextEdit too - when you want to delete a sensitive conversation, keeping sent messages is not a good thing to do :)
2) Fix the actual Clear View action by setting d->exchangedMessagesCount to 0 in clear(), otherwise last X messages from backlog are loaded from logger after re-initializing the chat view.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/chat-text-edit.h <span style="color: grey">(a14d716)</span></li>
<li>lib/chat-text-edit.cpp <span style="color: grey">(684ecd1)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(71650c2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113255/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>