<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113134/">http://git.reviewboard.kde.org/r/113134/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 6th, 2013, 6:43 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Needs update to notifyrc file and testing.
There are now 8 different entries to the notification configuration (from 3) for receiving messages these all need to be added.
IMHO this is maybe a bit too fine grained control, but as long as the defaults are OK I don't care.
Note changes to notifyrc file will be an i18n change so this will be for 0.8
</pre>
</blockquote>
<p>On October 7th, 2013, 1:28 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this may indeed be a little too fine-grained. Looking at thew current set of notification types made me realise that they need to be cleaned up anyway: Three different notification types each for Chatstyle or Emoticonset Installation? Seriously??? I'd strongly recommend to look at the notification types before 0.8 and reduce them a lot overall.
It may make sense to put the new ones created by this patch all in at first so we really see what we're up against and can merge types where possible.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The only notification types that I think might make sense to drop from this patch are for highlights in 1-to-1 chats. What do you think?</pre>
<br />
<p>- Leon</p>
<br />
<p>On October 6th, 2013, 4:56 p.m. UTC, Leon Handreke wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Leon Handreke.</div>
<p style="color: grey;"><i>Updated Oct. 6, 2013, 4:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=289348">289348</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Introduce new notification types for messages received in group chats
As a side-effect, there is now also a separate event type for
highlights received in an active window.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/notify-filter.cpp <span style="color: grey">(a5c8ba091ade6ece89ec2d3bec2ef24b94cb417f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113134/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>