<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112970/">http://git.reviewboard.kde.org/r/112970/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe wait 24 hours in case anyone else objects to their contacts being reset.</pre>
<br />
<p>- David</p>
<br />
<p>On September 27th, 2013, 11:52 p.m. UTC, Daniele E. Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniele E. Domenichelli.</div>
<p style="color: grey;"><i>Updated Sept. 27, 2013, 11:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">uniqueIdentifier is guaranteed to be unique by telepathy, object paths coming from different service could hypotetically be non-unique, even though I believe that the specs require to append the uniqueIdentifier to "/org/freedesktop/Telepathy/"... anyway it is shorter and since it is the value returned as "account" from kpeople query, I believe it should be the same value saved in ~/.local/share/telepathy/mission-control/accounts.cfg</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Switched a few times from objectPath to uniqueIdentifier, contacts are updated (tested with nepomuk shell), contact list still works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Models/accounts-tree-proxy-model.cpp <span style="color: grey">(c6002948093a22ecff9149651d41a030df838aa3)</span></li>
<li>kpeople/nepomuk-feeder/account.cpp <span style="color: grey">(161ea40ae609165a609a545b08a8d202dad07c1c)</span></li>
<li>kpeople/nepomuk-feeder/controller.cpp <span style="color: grey">(fa37b7e01734a2066261c3950d03f13ea034c02f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112970/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>