<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112688/">http://git.reviewboard.kde.org/r/112688/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- David</p>
<br />
<p>On September 21st, 2013, 4:25 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2013, 4:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use more sensbile icons for the toolbar. See screenshot. Main problems which I wanted to address:
* The "merge contacts" icon looks like it adds a contact.
* The "show grouped" icon is the "edit-group" icon which makes no sense and also looks weird
* The "show offline" icon is the "meeting-attending-tentative" which makes a) no sense and b) looks like it's disabled all the time.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nothing breaks by changing icons, does it?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contact-list-widget.h <span style="color: grey">(44fc8d5)</span></li>
<li>contact-list-widget.cpp <span style="color: grey">(98207c2)</span></li>
<li>main-widget.h <span style="color: grey">(c5eac93)</span></li>
<li>main-widget.cpp <span style="color: grey">(5f2557e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112688/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons.png">Suggested new icons, with "split group" icon</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons2.png">Suggested new icons, with "group contacts" icon</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/icons4.png">new "show offline" icon</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/17/newicons.png">New icons, next iteration</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/21/groups.png">"Show grouped" as radio buttons</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>