<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112688/">http://git.reviewboard.kde.org/r/112688/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 14th, 2013, 8:10 p.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about this? I agree it's not perfect but I still think it's a significant improvement.
I can either make the "show offline" icon as suggested look properly (we can include our own icon, right?), or we can leave that icon unchanged and just go with a subset of the other changes...
But at least the "merge contact" I'd really vote for changing.
Cheers,
Sven</pre>
</blockquote>
<p>On September 16th, 2013, 5:52 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">merge contact icon - totally for it.
offline/online contacts - somewhat works...I'd be pretty much ok with it
group icon - I don't like that much, not sure if we can find anything better though</pre>
</blockquote>
<p>On September 16th, 2013, 8:09 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We could move it to the menu. Then you don't need an icon.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good idea. It's not something you'd want to toggle all the time.
In turn, we could move the Group Chat button to the toolbar, since it really does not belong into the menu ;)
I'll submit a patch tomorrow doing that and then we can continue the discussion from there.</pre>
<br />
<p>- Sven</p>
<br />
<p>On September 12th, 2013, 7:16 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2013, 7:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use more sensbile icons for the toolbar. See screenshot. Main problems which I wanted to address:
* The "merge contacts" icon looks like it adds a contact.
* The "show grouped" icon is the "edit-group" icon which makes no sense and also looks weird
* The "show offline" icon is the "meeting-attending-tentative" which makes a) no sense and b) looks like it's disabled all the time.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nothing breaks by changing icons, does it?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>main-widget.cpp <span style="color: grey">(5f2557e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112688/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons.png">Suggested new icons, with "split group" icon</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons2.png">Suggested new icons, with "group contacts" icon</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/icons4.png">new "show offline" icon</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>