<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112658/">http://git.reviewboard.kde.org/r/112658/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 11th, 2013, 7:07 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this could be quite simplified with just the code below in teh contact delegate (it's the same as in the groups header):
if (option.state & QStyle::State_Open) {
style->drawPrimitive(QStyle::PE_IndicatorArrowDown, &expandSignOption, painter);
} else {
style->drawPrimitive(QStyle::PE_IndicatorArrowRight, &expandSignOption, painter);
}</pre>
</blockquote>
<p>On September 11th, 2013, 11:20 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I need the if (element == QStyle::PE_IndicatorBranch) {
because there are lots of other primitives being drawn (like scrollbars and such)
I need the if (option->state & QStyle::State_Children) {
because otherwise I draw right arrows for all contacts regardless of whether they have subcontacts or not</pre>
</blockquote>
<p>On September 11th, 2013, 11:28 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> I need the if (element == QStyle::PE_IndicatorBranch) {
But you wouldn't in the delegate as that paints only the item, no? option->state is then also available inside the delegate, so we can move it all there and not have any styles involved.</pre>
</blockquote>
<p>On September 11th, 2013, 11:34 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can't put it in the delegate because of the reason in my massive comment.
drawBranches() doesn't have a QStyleOption* passed.</pre>
</blockquote>
<p>On September 11th, 2013, 11:48 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The point is you don't need drawBranches() at all, this can all be done inside the delegate, which has QStyleOption passed.</pre>
</blockquote>
<p>On September 11th, 2013, 11:50 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But then I can't have separate click handling on the contact item and the arrow.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, yeah, handling that manually can be pita. Ok then, going to do proper review.</pre>
<br />
<p>- Martin</p>
<br />
<p>On September 10th, 2013, 11:56 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2013, 11:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Draw branches for contacts in KPeople mode
To me it's a lot easier to use and navigate and doesn't look too bad.
Requires https://git.reviewboard.kde.org/r/112657/
Fixes 2 of the release blocking bugs.
(https://bugs.kde.org/show_bug.cgi?id=324602 and https://bugs.kde.org/show_bug.cgi?id=324300)
These could be solved in other ways, for me this patch is mostly about fixing the problem of double clicking expanding (not reported).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contact-delegate-compact.cpp <span style="color: grey">(945def1565707691072fbcd62b70756ee4e3ee84)</span></li>
<li>contact-list-widget.cpp <span style="color: grey">(7c4c9308940828a923d3c196af51c12314114257)</span></li>
<li>contact-list-widget_p.h <span style="color: grey">(5baae8776702c9f0f8aa78584a04ef402dea1d61)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112658/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/facebook1.png">facebook1.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/arrows1_1.png">Just arrows, no lines.</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/fb1.png">Before</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>