<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112631/">http://git.reviewboard.kde.org/r/112631/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd like to test it but it doesn't build:
../KTp/Widgets/add-contact-dialog.cpp:108:49: error: ‘struct KTp::AddContactDialog::Private’ has no member named ‘m_accountManager’
Did you maybe forget to add that change?</pre>
<br />
<p>- Sven</p>
<br />
<p>On September 10th, 2013, 12:17 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2013, 12:17 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">https://bugs.kde.org/show_bug.cgi?id=324698
Having finished this patch I've realised this is totally the wrong solution to a problem that shouldn't exist.
It turns out we only get this bug because kpeople is using a separate account manager to the main contact list, which is wrong. I'm sure I've said many times about how we shouldn't put two account managers in the same application because we'll get weird problems. Clearly not enough times.
I have a plan to fix that properly with singleton returning standard factories..but it's too late to do that in 0.7. There's no other public way to share the account factory.
I think maybe we should ship this, and I'll remove it in 0.8? Thoughts?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Widgets/add-contact-dialog.h <span style="color: grey">(c12834a)</span></li>
<li>KTp/Widgets/add-contact-dialog.cpp <span style="color: grey">(fb34eb5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112631/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>