<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112549/">http://git.reviewboard.kde.org/r/112549/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112549/diff/1-2/?file=187411#file187411line86" style="color: black; font-weight: bold; text-decoration: underline;">kpeople/uiplugins/imdetailswidget.cpp</a>
<span style="font-weight: normal;">
(Diff revisions 1 - 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ImDetailsWidget::setPerson(PersonData *person)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">78</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">iconLabel</span><span class="o">-></span><span class="n">setPixmap</span><span class="p">(</span><span class="n">presence</span><span class="p">.</span><span class="n">icon</span><span class="p">().</span><span class="n">pixmap</span><span class="p">(</span><span class="mi">16</span><span class="p">,</span> <span class="mi">16</span><span class="p">));</span> <span class="c1">//FIXME - no hardcoded values. What's the right call here?</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">iconLabel</span><span class="o">-></span><span class="n">setPixmap</span><span class="p">(</span><span class="n">presence</span><span class="p">.</span><span class="n">icon</span><span class="p">().</span><span class="n">pixmap</span><span class="p">(</span><span class="n">IconSize</span><span class="p">(</span><span class="n">KIconLoader</span><span class="o">::</span><span class="n">Small</span><span class="p">),</span> <span class="n">IconSize</span><span class="p">(</span><span class="n">KIconLoader</span><span class="o">::</span><span class="n">Small</span><span class="p">)));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use QStyle::PM_SmallIconSize? :D
KIconLoader::Small is doubtfully better than a scalar and it's deprecated in KF5.</pre>
</div>
<br />
<p>- Aleix</p>
<br />
<p>On September 6th, 2013, 1:37 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 6, 2013, 1:37 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add kpeople plugin to show IM contacts in show details view</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kpeople/CMakeLists.txt <span style="color: grey">(10c3758aa0fd54177595a69afd4eb899664b4193)</span></li>
<li>kpeople/uiplugins/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpeople/uiplugins/imdetailswidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpeople/uiplugins/imdetailswidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpeople/uiplugins/imdetailswidgetplugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112549/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/snapshot2_2.png">Screenshot of show info dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>