<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112549/">http://git.reviewboard.kde.org/r/112549/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 6th, 2013, 12:35 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it could be useful... but what's the use-case?
Maybe we should have one more generic that displays the standard information about the subcontacts instead of just the IM? Like e-mail or phone...
It doesn't seem like you require ktp anyway for what you're showing, right?</pre>
</blockquote>
<p>On September 6th, 2013, 12:38 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>what's the use-case?
To see IM contacts from inside person viewer, to copy + paste addresses, etc.
>Maybe we should have one more generic that displays the standard information about the subcontacts instead of just the IM? Like e-mail or phone...
It does!
The entire right hand side of person-details-view is built on a plugin system. It's the same widget being shown here.
This is one of the plugins it requires KTp because it shows presence. In addition at some point I want it to show blocked-state, subscription state the account and have all the actions attached.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, so if we need to have a separate plugin for KTp then it's ok.
I'll give you a "ship it" once the issues are solved. (mainly the 16 thing XD)</pre>
<br />
<p>- Aleix</p>
<br />
<p>On September 6th, 2013, 12:05 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 6, 2013, 12:05 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add kpeople plugin to show IM contacts in show details view</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kpeople/CMakeLists.txt <span style="color: grey">(10c3758aa0fd54177595a69afd4eb899664b4193)</span></li>
<li>kpeople/uiplugins/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpeople/uiplugins/imdetailswidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpeople/uiplugins/imdetailswidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpeople/uiplugins/imdetailswidgetplugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112549/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/snapshot2_1.png">snapshot2_1.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>