<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112393/">http://git.reviewboard.kde.org/r/112393/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 54a073de1c70c4ab91e1145ff6e0953ed17eac53 by David Edmundson to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 31st, 2013, 12:08 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Vishesh Handa.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2013, 12:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Populate contact alias avatars and groups on initial load
Whilst this makes fetching data from Telepathy have a slightly higher
latency than inserting minimal data and then updating it the
stress this causes on Nepomuk and in particular anything using the database
having to update everything twice is much greater.
BUG: 322032
--
End result things will be much much faster. Especially if you have the contact list open during initial feeding.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Disbaled Nepomuk
Wiped database
Enabled Nepomuk
Had contact list open
Within a minute it had everything populated.
Contact list crashed a lot (unrelated known bug)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>account.cpp <span style="color: grey">(c21809ece8e08932565a15adcdb77836da7010ed)</span></li>
<li>controller.cpp <span style="color: grey">(0afb5d127c80caa690e7cbde629a95ef80fc9179)</span></li>
<li>nepomuk-storage.h <span style="color: grey">(a921e22c3315eed2dd825014ee3ae8250a039995)</span></li>
<li>nepomuk-storage.cpp <span style="color: grey">(7b05a222555aadf142c74c84cc37078261d56f2e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112393/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>