<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112393/">http://git.reviewboard.kde.org/r/112393/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 2nd, 2013, 7:18 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112393/diff/1/?file=185773#file185773line144" style="color: black; font-weight: bold; text-decoration: underline;">nepomuk-storage.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private Q_SLOTS:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">144</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">updateAlias</span><span class="p">(</span><span class="n">Nepomuk2</span><span class="o">::</span><span class="n">SimpleResource</span> <span class="o">&</span><span class="n">contactResource</span><span class="p">,</span> <span class="n">Nepomuk2</span><span class="o">::</span><span class="n">SimpleResource</span> <span class="o">&</span><span class="n">imAccountResource</span><span class="p">,</span> <span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">alias</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">145</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">updateContactGroups</span><span class="p">(</span><span class="n">Nepomuk2</span><span class="o">::</span><span class="n">SimpleResource</span> <span class="o">&</span><span class="n">contactResource</span><span class="p">,</span> <span class="k">const</span> <span class="n">QStringList</span> <span class="o">&</span><span class="n">groups</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">146</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">updateContactAvatar</span><span class="p">(</span><span class="n">Nepomuk2</span><span class="o">::</span><span class="n">SimpleResource</span> <span class="o">&</span><span class="n">contactResource</span><span class="p">,</span> <span class="n">Nepomuk2</span><span class="o">::</span><span class="n">SimpleResource</span> <span class="o">&</span><span class="n">imAccountResource</span><span class="p">,</span> <span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">AvatarData</span> <span class="o">&</span><span class="n">avatar</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm unsure if it's worth adding couple lines of code as new methods, mostly because the API is quite confusing already, this won't help much...also these are not used as slots.</pre>
</blockquote>
<p>On September 2nd, 2013, 12:50 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we don't we have duplication of code.
I think we'll edit one and not the other and it will all explode.</pre>
</blockquote>
<p>On September 2nd, 2013, 1:03 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fwiw, this class already has lots of code duplicated (even your updateContactGroups() has duplicated parts from setContactGroups(), so it has the same issue)</pre>
</blockquote>
<p>On September 2nd, 2013, 1:05 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What? No it doesn't.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, I compared my local version with your diff. Meh, make it non-slots and ship it.</pre>
<br />
<p>- Martin</p>
<br />
<p>On August 31st, 2013, 12:08 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Vishesh Handa.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2013, 12:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Populate contact alias avatars and groups on initial load
Whilst this makes fetching data from Telepathy have a slightly higher
latency than inserting minimal data and then updating it the
stress this causes on Nepomuk and in particular anything using the database
having to update everything twice is much greater.
BUG: 322032
--
End result things will be much much faster. Especially if you have the contact list open during initial feeding.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Disbaled Nepomuk
Wiped database
Enabled Nepomuk
Had contact list open
Within a minute it had everything populated.
Contact list crashed a lot (unrelated known bug)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>account.cpp <span style="color: grey">(c21809ece8e08932565a15adcdb77836da7010ed)</span></li>
<li>controller.cpp <span style="color: grey">(0afb5d127c80caa690e7cbde629a95ef80fc9179)</span></li>
<li>nepomuk-storage.h <span style="color: grey">(a921e22c3315eed2dd825014ee3ae8250a039995)</span></li>
<li>nepomuk-storage.cpp <span style="color: grey">(7b05a222555aadf142c74c84cc37078261d56f2e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112393/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>